[GitHub] [calcite] jinxing64 commented on a change in pull request #1757: [CALCITE-3716] ResultSetMetaData.getTableName should return empty str…

[GitBox <gi...@apache.org>]

jinxing64 commented on a change in pull request #1757: [CALCITE-3716] ResultSetMetaData.getTableName should return empty str…
URL: https://github.com/apache/calcite/pull/1757#discussion_r366706059
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/test/TableInRootSchemaTest.java
 ##########
 @@ -75,14 +74,14 @@
     final ResultSetMetaData resultSetMetaData = resultSet.getMetaData();
     assertThat(resultSetMetaData.getColumnName(1), equalTo("A"));
     assertThat(resultSetMetaData.getTableName(1), equalTo("SAMPLE"));
-    assertThat(resultSetMetaData.getSchemaName(1), nullValue());
+    assertThat(resultSetMetaData.getSchemaName(1), equalTo(""));
     assertThat(resultSetMetaData.getColumnClassName(1),
         equalTo("java.lang.String"));
     // Per JDBC, column name should be null. But DBUnit requires every column
     // to have a name, so the driver uses the label.
 
 Review comment:
   The doc is for column name, which is not changed by this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services