You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/01/15 03:57:32 UTC

Review Request 29916: Pass LDAP URL and Principal container DN to Active Directory operations handler

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29916/
-----------------------------------------------------------

Review request for Ambari, John Speidel, Robert Nettleton, and Yusaku Sako.


Bugs: AMBARI-9055
    https://issues.apache.org/jira/browse/AMBARI-9055


Repository: ambari


Description
-------

Pass LDAP URL and Principal container DN to Active Directory operations handler.

The data will be stored in the `kerberos-env` configuration using the following properties:

* ldap_url - The URL to the Active Directory LDAP Interface
* container_dn - The distinguished name (DN) of the container used store service principals


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 626d130 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java 01913e4 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 38ca320 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java 5a1310d 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java a717b90 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java 2f91826 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java a70b412 
  ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java e32524a 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java d95dc5b 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactoryTest.java 5ec519d 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java e86656d 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 4a1e399 
  ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java 3bbb220 

Diff: https://reviews.apache.org/r/29916/diff/


Testing
-------

Manually tested in test cluster

Updated the following unit tests:
* `org.apache.ambari.server.controller.KerberosHelperTest`
* `org.apache.ambari.server.serveraction.kerberos.ADKerberosOperationHandlerTest`
* `org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerFactoryTest`
* `org.apache.ambari.server.serveraction.kerberos.MITKerberosOperationHandlerTest`
* `org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest`

#Jenkins Test Results

Running org.apache.ambari.server.controller.KerberosHelperTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.652 sec

Running org.apache.ambari.server.serveraction.kerberos.ADKerberosOperationHandlerTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.442 sec

Running org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerFactoryTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.214 sec

Running org.apache.ambari.server.serveraction.kerberos.MITKerberosOperationHandlerTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.421 sec

Running org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.176 sec

All ambari-server tests
Tests run: 2537, Failures: 0, Errors: 0, Skipped: 15

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 45:05 min
[INFO] Finished at: 2015-01-15T02:36:01+00:00
[INFO] Final Memory: 43M/485M
[INFO] ------------------------------------------------------------------------


Thanks,

Robert Levas


Re: Review Request 29916: Pass LDAP URL and Principal container DN to Active Directory operations handler

Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29916/#review68198
-----------------------------------------------------------

Ship it!


Ship It!

- John Speidel


On Jan. 15, 2015, 2:57 a.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29916/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2015, 2:57 a.m.)
> 
> 
> Review request for Ambari, John Speidel, Robert Nettleton, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-9055
>     https://issues.apache.org/jira/browse/AMBARI-9055
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Pass LDAP URL and Principal container DN to Active Directory operations handler.
> 
> The data will be stored in the `kerberos-env` configuration using the following properties:
> 
> * ldap_url - The URL to the Active Directory LDAP Interface
> * container_dn - The distinguished name (DN) of the container used store service principals
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 626d130 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java 01913e4 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 38ca320 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java 5a1310d 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java a717b90 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java 2f91826 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java a70b412 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java e32524a 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java d95dc5b 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactoryTest.java 5ec519d 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java e86656d 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 4a1e399 
>   ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java 3bbb220 
> 
> Diff: https://reviews.apache.org/r/29916/diff/
> 
> 
> Testing
> -------
> 
> Manually tested in test cluster
> 
> Updated the following unit tests:
> * `org.apache.ambari.server.controller.KerberosHelperTest`
> * `org.apache.ambari.server.serveraction.kerberos.ADKerberosOperationHandlerTest`
> * `org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerFactoryTest`
> * `org.apache.ambari.server.serveraction.kerberos.MITKerberosOperationHandlerTest`
> * `org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest`
> 
> #Jenkins Test Results
> 
> Running org.apache.ambari.server.controller.KerberosHelperTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.652 sec
> 
> Running org.apache.ambari.server.serveraction.kerberos.ADKerberosOperationHandlerTest
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.442 sec
> 
> Running org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerFactoryTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.214 sec
> 
> Running org.apache.ambari.server.serveraction.kerberos.MITKerberosOperationHandlerTest
> Tests run: 9, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.421 sec
> 
> Running org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.176 sec
> 
> All ambari-server tests
> Tests run: 2537, Failures: 0, Errors: 0, Skipped: 15
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 45:05 min
> [INFO] Finished at: 2015-01-15T02:36:01+00:00
> [INFO] Final Memory: 43M/485M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Re: Review Request 29916: Pass LDAP URL and Principal container DN to Active Directory operations handler

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29916/
-----------------------------------------------------------

(Updated Jan. 15, 2015, 5:34 a.m.)


Review request for Ambari, John Speidel, Robert Nettleton, and Yusaku Sako.


Changes
-------

Removed commented out constants from `org.apache.ambari.server.serveraction.kerberos.ADKerberosOperationHandlerTest`


Bugs: AMBARI-9055
    https://issues.apache.org/jira/browse/AMBARI-9055


Repository: ambari


Description
-------

Pass LDAP URL and Principal container DN to Active Directory operations handler.

The data will be stored in the `kerberos-env` configuration using the following properties:

* ldap_url - The URL to the Active Directory LDAP Interface
* container_dn - The distinguished name (DN) of the container used store service principals


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 5e3e612 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java 01913e4 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 38ca320 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java 5a1310d 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java a717b90 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java 7edd889 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java a70b412 
  ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java e32524a 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java d95dc5b 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactoryTest.java 5ec519d 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java e86656d 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 4a1e399 
  ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java 3bbb220 

Diff: https://reviews.apache.org/r/29916/diff/


Testing
-------

Manually tested in test cluster

Updated the following unit tests:
* `org.apache.ambari.server.controller.KerberosHelperTest`
* `org.apache.ambari.server.serveraction.kerberos.ADKerberosOperationHandlerTest`
* `org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerFactoryTest`
* `org.apache.ambari.server.serveraction.kerberos.MITKerberosOperationHandlerTest`
* `org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest`

#Jenkins Test Results

Running org.apache.ambari.server.controller.KerberosHelperTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.652 sec

Running org.apache.ambari.server.serveraction.kerberos.ADKerberosOperationHandlerTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.442 sec

Running org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerFactoryTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.214 sec

Running org.apache.ambari.server.serveraction.kerberos.MITKerberosOperationHandlerTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.421 sec

Running org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.176 sec

All ambari-server tests
Tests run: 2537, Failures: 0, Errors: 0, Skipped: 15

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 45:05 min
[INFO] Finished at: 2015-01-15T02:36:01+00:00
[INFO] Final Memory: 43M/485M
[INFO] ------------------------------------------------------------------------


Thanks,

Robert Levas