You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2020/10/11 18:37:02 UTC

[GitHub] [royale-asjs] SolidSoft-Lda opened a new issue #917: Jewel ComboBox freeze with SearchFilter

SolidSoft-Lda opened a new issue #917:
URL: https://github.com/apache/royale-asjs/issues/917


   Hi,
   
   I found a bug with Jewel ComboBox and SearchFilter bead.
   This can be easy reproduced with several itens with similar options however it can be simulated on Tour de Jewel.
   
   Steps to reproduce:
   1. Locate ComboBox on Tour de Jewel components;
   2. Go to Local Search Filter sample;
   3. Select any item with mouse;
   4. Select all text and type "i";
   5. The only option will be "Iron Man" and at this point you can't select the option or close the list and the application will freeze.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] carlosrovira closed issue #917: Jewel ComboBox freeze with SearchFilter

Posted by GitBox <gi...@apache.org>.
carlosrovira closed issue #917:
URL: https://github.com/apache/royale-asjs/issues/917


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] SolidSoft-Lda commented on issue #917: Jewel ComboBox freeze with SearchFilter

Posted by GitBox <gi...@apache.org>.
SolidSoft-Lda commented on issue #917:
URL: https://github.com/apache/royale-asjs/issues/917#issuecomment-708068920


   After I bring the SearchFilter bead to my project, I found a fix or workaround to this bug.
   
   On SearchFilter.as, I added this on my side:
           public override function set list(value:List):void
           {
               super.list = value;
               COMPILE::JS
               {
               list.addEventListener(MouseEvent.CLICK, onListClick);
               }
           }
   
           private function onListClick(event:MouseEvent):void
           {
               comboView.popUpVisible = false;
           }
   
   If is OK, I can commit it.
   I started a discussion on mailing list.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] carlosrovira commented on issue #917: Jewel ComboBox freeze with SearchFilter

Posted by GitBox <gi...@apache.org>.
carlosrovira commented on issue #917:
URL: https://github.com/apache/royale-asjs/issues/917#issuecomment-708280692


   Hi Hugo,
   
   I'm reopening since the bug is still there. It's better to close when it's solved really on the repo. Also, if a commit solves it it can be close directly by using "fixed #<issue-number>" on the description.
   
   As I commented I get a RTE with this solution in TDJ, so I think something is not completely right. I couldn't still check the issue and the solution myself. Just tried your snippet.
   
   Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] carlosrovira commented on issue #917: Jewel ComboBox freeze with SearchFilter

Posted by GitBox <gi...@apache.org>.
carlosrovira commented on issue #917:
URL: https://github.com/apache/royale-asjs/issues/917#issuecomment-712660849


   Thanks Hugo! going to review :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] carlosrovira commented on issue #917: Jewel ComboBox freeze with SearchFilter

Posted by GitBox <gi...@apache.org>.
carlosrovira commented on issue #917:
URL: https://github.com/apache/royale-asjs/issues/917#issuecomment-716204120


   just recently committed your fix fro PR 922


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] SolidSoft-Lda closed issue #917: Jewel ComboBox freeze with SearchFilter

Posted by GitBox <gi...@apache.org>.
SolidSoft-Lda closed issue #917:
URL: https://github.com/apache/royale-asjs/issues/917


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] SolidSoft-Lda commented on issue #917: Jewel ComboBox freeze with SearchFilter

Posted by GitBox <gi...@apache.org>.
SolidSoft-Lda commented on issue #917:
URL: https://github.com/apache/royale-asjs/issues/917#issuecomment-712511583


   Hi Carlos,
   
   Instead of monkey patch, I refreshed my fork, applied the fix, compile with ant and tested directly on TDJ.
   Then, I just commit and create a pull request: https://github.com/apache/royale-asjs/pull/922
   
   Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org