You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/26 03:58:23 UTC
[GitHub] [doris] etcZYP opened a new pull request, #15356: [Enhancement](fe): replace assertTrue(X.equals(X)) with assertEquals
etcZYP opened a new pull request, #15356:
URL: https://github.com/apache/doris/pull/15356
# Proposed changes
Issue Number: close #11916
## Problem summary
Replace assertTrue(X.equals(X)) with assertEquals.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [x] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #15356: [Enhancement](fe): replace assertTrue(X.equals(X)) with assertEquals
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #15356:
URL: https://github.com/apache/doris/pull/15356#issuecomment-1365163450
You need rebase the master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15356: [Enhancement](fe): replace assertTrue(X.equals(X)) with assertEquals
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15356:
URL: https://github.com/apache/doris/pull/15356#issuecomment-1365278372
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] etcZYP commented on pull request #15356: [Enhancement](fe): replace assertTrue(X.equals(X)) with assertEquals
Posted by GitBox <gi...@apache.org>.
etcZYP commented on PR #15356:
URL: https://github.com/apache/doris/pull/15356#issuecomment-1364948281
done but build failed still
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] etcZYP commented on pull request #15356: [Enhancement](fe): replace assertTrue(X.equals(X)) with assertEquals
Posted by GitBox <gi...@apache.org>.
etcZYP commented on PR #15356:
URL: https://github.com/apache/doris/pull/15356#issuecomment-1364951576
done but still build failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener commented on a diff in pull request #15356: [Enhancement](fe): replace assertTrue(X.equals(X)) with assertEquals
Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #15356:
URL: https://github.com/apache/doris/pull/15356#discussion_r1057075252
##########
fe/fe-core/src/test/java/org/apache/doris/load/TabletLoadInfoTest.java:
##########
@@ -60,10 +60,10 @@ public void testSerialization() throws Exception {
Assert.assertEquals("hdfs://host:port/dir", tabletLoadInfo1.getFilePath());
Assert.assertEquals(1L, tabletLoadInfo1.getFileSize());
-
- Assert.assertTrue(tabletLoadInfo1.equals(tabletLoadInfo));
- Assert.assertTrue(rTabletLoadInfo0.equals(tabletLoadInfo0));
- Assert.assertFalse(rTabletLoadInfo0.equals(tabletLoadInfo1));
+
Review Comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #15356: [Enhancement](fe): replace assertTrue(X.equals(X)) with assertEquals
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #15356:
URL: https://github.com/apache/doris/pull/15356#issuecomment-1364906864
please also revert changes in `fe/fe-common/src/test/java/org/apache/doris/common/io/BitmapValueTest.java`
Because `BitmapValue` doesn't implement `equals() and hashcode()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] etcZYP commented on pull request #15356: [Enhancement](fe): replace assertTrue(X.equals(X)) with assertEquals
Posted by GitBox <gi...@apache.org>.
etcZYP commented on PR #15356:
URL: https://github.com/apache/doris/pull/15356#issuecomment-1364887134
@jackwener can you plz review my pr? there are no compile errors but build failed though i use IntelliJ IDEA
to open fe-common and there is no error prompt.
the error appears in file BitmapValueTest and line 416 210 304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] etcZYP commented on pull request #15356: [Enhancement](fe): replace assertTrue(X.equals(X)) with assertEquals
Posted by GitBox <gi...@apache.org>.
etcZYP commented on PR #15356:
URL: https://github.com/apache/doris/pull/15356#issuecomment-1365157448
apache master exit bug or mine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #15356: [Enhancement](fe): replace assertTrue(X.equals(X)) with assertEquals
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #15356:
URL: https://github.com/apache/doris/pull/15356#issuecomment-1364970402
Current master exit bug, wait for bugfix merge😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener merged pull request #15356: [Enhancement](fe): replace assertTrue(X.equals(X)) with assertEquals
Posted by GitBox <gi...@apache.org>.
jackwener merged PR #15356:
URL: https://github.com/apache/doris/pull/15356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener commented on a diff in pull request #15356: [Enhancement](fe): replace assertTrue(X.equals(X)) with assertEquals
Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #15356:
URL: https://github.com/apache/doris/pull/15356#discussion_r1057075100
##########
fe/fe-core/src/test/java/org/apache/doris/load/TabletLoadInfoTest.java:
##########
@@ -60,10 +60,10 @@ public void testSerialization() throws Exception {
Assert.assertEquals("hdfs://host:port/dir", tabletLoadInfo1.getFilePath());
Assert.assertEquals(1L, tabletLoadInfo1.getFileSize());
-
- Assert.assertTrue(tabletLoadInfo1.equals(tabletLoadInfo));
- Assert.assertTrue(rTabletLoadInfo0.equals(tabletLoadInfo0));
- Assert.assertFalse(rTabletLoadInfo0.equals(tabletLoadInfo1));
+
Review Comment:
It will make build failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener commented on a diff in pull request #15356: [Enhancement](fe): replace assertTrue(X.equals(X)) with assertEquals
Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #15356:
URL: https://github.com/apache/doris/pull/15356#discussion_r1057074250
##########
fe/fe-core/src/test/java/org/apache/doris/load/TabletLoadInfoTest.java:
##########
@@ -60,10 +60,10 @@ public void testSerialization() throws Exception {
Assert.assertEquals("hdfs://host:port/dir", tabletLoadInfo1.getFilePath());
Assert.assertEquals(1L, tabletLoadInfo1.getFileSize());
-
- Assert.assertTrue(tabletLoadInfo1.equals(tabletLoadInfo));
- Assert.assertTrue(rTabletLoadInfo0.equals(tabletLoadInfo0));
- Assert.assertFalse(rTabletLoadInfo0.equals(tabletLoadInfo1));
+
Review Comment:
redundant blank.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15356: [Enhancement](fe): replace assertTrue(X.equals(X)) with assertEquals
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15356:
URL: https://github.com/apache/doris/pull/15356#issuecomment-1365230927
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35 seconds
load time: 633 seconds
storage size: 17122870560 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221226145145_clickbench_pr_69015.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15356: [Enhancement](fe): replace assertTrue(X.equals(X)) with assertEquals
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15356:
URL: https://github.com/apache/doris/pull/15356#issuecomment-1365278389
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org