You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Jostein Chr. Andersen" <jo...@josander.net> on 2005/02/02 14:35:02 UTC

Issue #1559 - Windows Service needed server side for svnserve

Hi,

I'll grab this issue within a few days if no one objects or are planning 
to do something about it.

This is what I'll do:

* Include Magnus Norddahl's SVN Service Wrapper for Windows
  (SVNService) with the installer.
* Let the installer do the setup of SVNService if the user choose to
  do so. That means that the user can choose between Apache or svnserve
  if he/she want to use a Subversion Server under Windows.

Tips/thoughts from users of svnserve for Windows are welcome!

Links:
  http://subversion.tigris.org/issues/show_bug.cgi?id=1559
  http://dark.clansoft.dk/~mbn/svnservice/

Thanks,
Jostein


-- 
http://www.josander.net/en/contact/

Re: Issue #1559 - Windows Service needed server side for svnserve

Posted by "Jostein Chr. Andersen" <jo...@josander.net>.
On Wednesday 02 February 2005 19.03, Max Bowsher wrote:
...
> > A Microsoft copyright notice occurs (C 1993-1997)in the heading of
> > service.h. and service.c (wich is a modified MS file). Is service.c
> > something we are aloved to have in the contrib area? service.h
> > should not be any problem, it's a VC compiler related include file
> > if I recall right.
>
> I previously took the web page at face value.
> Now I have examined the copyright headers, I (personally) feel that
> the legal status of this code is sufficiently dubious that it is not
> suitable for distribution in either source *or* binary forms in *any*
> way from subversion.tigris.org.

Well, the binary should not be a problem. Generally speaking: if someone 
buys MS VC - as the author of SVNService appare to have done, then the 
author is free to use the included MS VC header (such as service.h) and 
(modified) MS example files (such as service.c) and compile and give hes 
binary program(s) away for free as freeware,public domain or whatever.

So my conclusion is that we should not keep the sources in the repository 
or somewhere else (and CollabNet itself do not have VC AFAIK), they have 
copyright notices from Microsoft and the author, but we are free to keep 
a copy of the binary file somewhere at the subversion project, for 
example in the file sharing area and/or distributed with a Windows 
installer.


Jostein

-- 
http://www.josander.net/en/contact/

Re: Issue #1559 - Windows Service needed server side for svnserve

Posted by Max Bowsher <ma...@ukf.net>.
Jostein Chr. Andersen wrote:
> On Wednesday 02 February 2005 16.50, Max Bowsher wrote:
> ...
>>> This is what I'll do:
>>>
>>> * Include Magnus Norddahl's SVN Service Wrapper for Windows
>>>   (SVNService) with the installer.
>>
>> I would suggest that SVNService should go into contrib/, be built as
>> part of the standard Windows build, and then be built into the
>> installer from there, rather than be an installer-only thing.
>
> Good idea, but I'm not sure that the contents of SVNService.zip is public
> domain enought (however, I think the binary is safe).
>
> A Microsoft copyright notice occurs (C 1993-1997)in the heading of
> service.h. and service.c (wich is a modified MS file). Is service.c
> something we are aloved to have in the contrib area? service.h should
> not be any problem, it's a VC compiler related include file if I recall
> right.

I previously took the web page at face value.
Now I have examined the copyright headers, I (personally) feel that the 
legal status of this code is sufficiently dubious that it is not suitable 
for distribution in either source *or* binary forms in *any* way from 
subversion.tigris.org.

> 3) Would 'contrib/win-svnservice' be ok in the trunk?

I'd be happy with 'contrib/windows-service' for a legally suitable piece of 
code.

Max.




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Issue #1559 - Windows Service needed server side for svnserve

Posted by "Jostein Chr. Andersen" <jo...@josander.net>.
On Wednesday 02 February 2005 16.50, Max Bowsher wrote:
...
> > This is what I'll do:
> >
> > * Include Magnus Norddahl's SVN Service Wrapper for Windows
> >   (SVNService) with the installer.
>
> I would suggest that SVNService should go into contrib/, be built as
> part of the standard Windows build, and then be built into the
> installer from there, rather than be an installer-only thing.

Good idea, but I'm not sure that the contents of SVNService.zip is public 
domain enought (however, I think the binary is safe).

A Microsoft copyright notice occurs (C 1993-1997)in the heading of 
service.h. and service.c (wich is a modified MS file). Is service.c 
something we are aloved to have in the contrib area? service.h should 
not be any problem, it's a VC compiler related include file if I recall 
right.

Three more things:
1) The binary in the zip file probably have to go elswhere because 
binaries should not be in the repository - and I don't want diffrent 
versions of a binary compiled from one source. It can be placed in the 
same place as the svnpath binary (which will be obsolete soon, Inno 
Setup will do it 100%) wich is currently:

  http://subversion.tigris.org/servlets/ProjectDocumentList?folderID=2728

This directory is actually named "Development snapshots of Windows 
binaries".

2) Is it enough to just include the following files in the contrib area 
(or are all the files in SVNService.zip needed)?

  log_messages.h
  log_messages.rc
  resource.h
  service.c
  SVNService.dsp
  SVNService.dsw
  SVNService.ico
  SVNService.rc

  ...and exclude the following ones?
  MSG00001.bin
  log_messages.mc
  service.h

3) Would 'contrib/win-svnservice' be ok in the trunk?

Jostein

-- 
http://www.josander.net/en/contact/

Re: Issue #1559 - Windows Service needed server side for svnserve

Posted by Max Bowsher <ma...@ukf.net>.
Jostein Chr. Andersen wrote:
> Hi,
>
> I'll grab this issue within a few days if no one objects or are planning
> to do something about it.

Thanks! Help in reducing the open issue count is always appreciated!

> This is what I'll do:
>
> * Include Magnus Norddahl's SVN Service Wrapper for Windows
>   (SVNService) with the installer.

I would suggest that SVNService should go into contrib/, be built as part of
the standard Windows build, and then be built into the installer from there,
rather than be an installer-only thing.

Max.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org