[parquet-format] branch master updated: PARQUET-2013: Replace back "should" with "must" (#171)

[we...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-format.git


The following commit(s) were added to refs/heads/master by this push:
     new 2e23a11  PARQUET-2013: Replace back "should" with "must" (#171)
2e23a11 is described below

commit 2e23a1168f50e83cacbbf970259a947e430ebe3a
Author: Antoine Pitrou <an...@python.org>
AuthorDate: Mon Apr 5 00:43:18 2021 +0200

    PARQUET-2013: Replace back "should" with "must" (#171)
---
 LogicalTypes.md                | 2 +-
 src/main/thrift/parquet.thrift | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/LogicalTypes.md b/LogicalTypes.md
index 4b9a8df..e61ea25 100644
--- a/LogicalTypes.md
+++ b/LogicalTypes.md
@@ -50,7 +50,7 @@ this way allowing more flexible API, logical types can have type parameters.
 `ConvertedType` is deprecated. However, to maintain compatibility with old writers,
 Parquet readers should be able to read and interpret `ConvertedType` annotations
 in case `LogicalType` annotations are not present. Parquet writers must always write
-`LogicalType` annotations where applicable, but should also write the corresponding
+`LogicalType` annotations where applicable, but must also write the corresponding
 `ConvertedType` annotations (if any) to maintain compatibility with old readers.
 
 Compatibility considerations are mentioned for each annotation in the corresponding section.
diff --git a/src/main/thrift/parquet.thrift b/src/main/thrift/parquet.thrift
index 1dc6958..c6eeea9 100644
--- a/src/main/thrift/parquet.thrift
+++ b/src/main/thrift/parquet.thrift
@@ -317,15 +317,15 @@ struct BsonType {
  * LogicalType annotations to replace ConvertedType.
  *
  * To maintain compatibility, implementations using LogicalType for a
- * SchemaElement should also set the corresponding ConvertedType from the
- * following table.
+ * SchemaElement must also set the corresponding ConvertedType (if any)
+ * from the following table.
  */
 union LogicalType {
   1:  StringType STRING       // use ConvertedType UTF8
   2:  MapType MAP             // use ConvertedType MAP
   3:  ListType LIST           // use ConvertedType LIST
   4:  EnumType ENUM           // use ConvertedType ENUM
-  5:  DecimalType DECIMAL     // use ConvertedType DECIMAL
+  5:  DecimalType DECIMAL     // use ConvertedType DECIMAL + SchemaElement.{scale, precision}
   6:  DateType DATE           // use ConvertedType DATE
 
   // use ConvertedType TIME_MICROS for TIME(isAdjustedToUTC = *, unit = MICROS)
@@ -341,7 +341,7 @@ union LogicalType {
   11: NullType UNKNOWN        // no compatible ConvertedType
   12: JsonType JSON           // use ConvertedType JSON
   13: BsonType BSON           // use ConvertedType BSON
-  14: UUIDType UUID
+  14: UUIDType UUID           // no compatible ConvertedType
 }
 
 /**