You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/01/18 10:38:30 UTC
[GitHub] [netbeans] dbalek opened a new pull request #2686: Fix broken links to images in the extension's readme.
dbalek opened a new pull request #2686:
URL: https://github.com/apache/netbeans/pull/2686
Adding `--baseImagesUrl` option to the extension's build script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek merged pull request #2686: Fix broken links to images in the extension's readme.
Posted by GitBox <gi...@apache.org>.
dbalek merged pull request #2686:
URL: https://github.com/apache/netbeans/pull/2686
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek commented on a change in pull request #2686: Fix broken links to images in the extension's readme.
Posted by GitBox <gi...@apache.org>.
dbalek commented on a change in pull request #2686:
URL: https://github.com/apache/netbeans/pull/2686#discussion_r560830241
##########
File path: java/java.lsp.server/build.xml
##########
@@ -96,6 +96,8 @@
</exec>
<exec executable="${build.dir}/vsce/node_modules/vsce/out/vsce" failonerror="true" dir="${basedir}/vscode">
<arg value="package" />
+ <arg value="--baseImagesUrl" />
+ <arg value="https://github.com/apache/netbeans/raw/master/java/java.lsp.server/vscode" />
Review comment:
Fixed as requested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2686: Fix broken links to images in the extension's readme.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2686:
URL: https://github.com/apache/netbeans/pull/2686#discussion_r559921517
##########
File path: java/java.lsp.server/build.xml
##########
@@ -96,6 +96,8 @@
</exec>
<exec executable="${build.dir}/vsce/node_modules/vsce/out/vsce" failonerror="true" dir="${basedir}/vscode">
<arg value="package" />
+ <arg value="--baseImagesUrl" />
+ <arg value="https://github.com/apache/netbeans/raw/master/java/java.lsp.server/vscode" />
Review comment:
Using `master` means that such images can never be removed. Wouldn't it be more proper to obtain the actual commit ID and use it in the URL?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek merged pull request #2686: Fix broken links to images in the extension's readme.
Posted by GitBox <gi...@apache.org>.
dbalek merged pull request #2686:
URL: https://github.com/apache/netbeans/pull/2686
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists