You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/12/19 11:25:16 UTC

[GitHub] [calcite] JiajunBernoulli commented on pull request #2997: [CALCITE-5416] RelToSql converter generates invalid code when merging…

JiajunBernoulli commented on PR #2997:
URL: https://github.com/apache/calcite/pull/2997#issuecomment-1357496002

   > LGTM, with the suggestions I made.
   > 
   > Also, improve the commit message and bug summary. Mention MySQL, JDBC adapter, GROUP BY WITH ROLLUP, ORDER BY.
   
   Thanks for your review. 
   
   > LGTM, with the suggestions I made.
   > 
   > Also, improve the commit message and bug summary. Mention MySQL, JDBC adapter, GROUP BY WITH ROLLUP, ORDER BY.
   
   Thanks for your review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org