You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/07/12 04:15:47 UTC
[GitHub] [netbeans] junichi11 opened a new pull request #2250: Minor improvements for php.api.phpmodule
junichi11 opened a new pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250
- Add the `isSupportedVersion()` method to the PhpVersion
- Check whether the version is supported yet by PHP official
- Improve the `getLegacy()` method
- Add the `getFirstError()` and the `getFirstWarning()` methods to the `ValidationResult` class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#discussion_r455120372
##########
File path: php/php.api.phpmodule/manifest.mf
##########
@@ -1,4 +1,4 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.php.api.phpmodule
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/php/api/phpmodule/resources/Bundle.properties
-OpenIDE-Module-Specification-Version: 2.71
+OpenIDE-Module-Specification-Version: 2.72
Review comment:
> OK, so some other module has to depend on it (my bet is `php.project`).
Yes, `php.project`, `php.editor`, etc.
> So, let's keep it as it is
OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on a change in pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#discussion_r455027077
##########
File path: php/php.api.phpmodule/src/org/netbeans/modules/php/api/validation/ValidationResult.java
##########
@@ -98,6 +113,20 @@ public boolean hasWarnings() {
}
+ /**
+ * Get the first warning.
+ *
+ * @return the first warning or {@code null} if there are no errors
Review comment:
Please, let me know if you are going to change it. If not, I will merge this PR. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#discussion_r455120921
##########
File path: php/php.api.phpmodule/src/org/netbeans/modules/php/api/validation/ValidationResult.java
##########
@@ -98,6 +113,20 @@ public boolean hasWarnings() {
}
+ /**
+ * Get the first warning.
+ *
+ * @return the first warning or {@code null} if there are no errors
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#discussion_r455109516
##########
File path: php/php.api.phpmodule/src/org/netbeans/modules/php/api/validation/ValidationResult.java
##########
@@ -98,6 +113,20 @@ public boolean hasWarnings() {
}
+ /**
+ * Get the first warning.
+ *
+ * @return the first warning or {@code null} if there are no errors
Review comment:
Will fix it, sorry...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on a change in pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#discussion_r454833148
##########
File path: php/php.api.phpmodule/manifest.mf
##########
@@ -1,4 +1,4 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.php.api.phpmodule
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/php/api/phpmodule/resources/Bundle.properties
-OpenIDE-Module-Specification-Version: 2.71
+OpenIDE-Module-Specification-Version: 2.72
Review comment:
Don't we want to increase the dependency version in `php.kit`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#discussion_r454990296
##########
File path: php/php.api.phpmodule/src/org/netbeans/modules/php/api/validation/ValidationResult.java
##########
@@ -80,6 +81,20 @@ public boolean hasErrors() {
return new ArrayList<>(errors);
}
+ /**
+ * Get the first error.
+ *
+ * @return the first error.
Review comment:
Fixed.
https://github.com/apache/netbeans/compare/5685f82c7815b1441ffe2188fa7c327dc79c8685..6c2e311da592782e23c67563514a380699ed4314
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#discussion_r454983531
##########
File path: php/php.api.phpmodule/src/org/netbeans/modules/php/api/validation/ValidationResult.java
##########
@@ -80,6 +81,20 @@ public boolean hasErrors() {
return new ArrayList<>(errors);
}
+ /**
+ * Get the first error.
+ *
+ * @return the first error.
+ * @since 2.72
+ */
+ @CheckForNull
+ public Message getFirstError() {
+ if (hasErrors()) {
+ return errors.get(0);
+ }
+ return null;
+ }
Review comment:
Makes sense. I agree with you. I'll keep this. Thanks a lot!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#discussion_r453265442
##########
File path: php/php.api.phpmodule/src/org/netbeans/modules/php/api/validation/ValidationResult.java
##########
@@ -80,6 +81,20 @@ public boolean hasErrors() {
return new ArrayList<>(errors);
}
+ /**
+ * Get the first error.
+ *
+ * @return the first error.
+ * @since 2.72
+ */
+ @CheckForNull
+ public Message getFirstError() {
+ if (hasErrors()) {
+ return errors.get(0);
+ }
+ return null;
+ }
Review comment:
I also thought other implementations:
#### Create `Message.EMPTY` and return it instead of `null`
```java
public Message getFirstError() {
if (hasErrors()) {
return errors.get(0);
}
return Message.EMPTY;
}
public static final class Message {
public static final Message EMPTY = new Message("", "");
```
#### Use Optional
```java
public Optional<Message> getFirstError() {
if (hasErrors()) {
return Optional.of(errors.get(0));
}
return Optional.empty();
}
```
Which is better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#issuecomment-658583898
@junichi11 Looks good to me, just a few comments/questions. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik merged pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
tmysik merged pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on a change in pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#discussion_r454832665
##########
File path: php/php.api.phpmodule/src/org/netbeans/modules/php/api/validation/ValidationResult.java
##########
@@ -98,6 +113,20 @@ public boolean hasWarnings() {
}
+ /**
+ * Get the first warning.
+ *
+ * @return the first warning.
Review comment:
The same note as above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#discussion_r454985625
##########
File path: php/php.api.phpmodule/manifest.mf
##########
@@ -1,4 +1,4 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.php.api.phpmodule
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/php/api/phpmodule/resources/Bundle.properties
-OpenIDE-Module-Specification-Version: 2.71
+OpenIDE-Module-Specification-Version: 2.72
Review comment:
It seems that `php.kit` doesn't have `phpmodule.api`as module-dependencies: https://github.com/apache/netbeans/blob/master/php/php.kit/nbproject/project.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#discussion_r454984008
##########
File path: php/php.api.phpmodule/src/org/netbeans/modules/php/api/validation/ValidationResult.java
##########
@@ -80,6 +81,20 @@ public boolean hasErrors() {
return new ArrayList<>(errors);
}
+ /**
+ * Get the first error.
+ *
+ * @return the first error.
Review comment:
Will fix. Thanks!
##########
File path: php/php.api.phpmodule/src/org/netbeans/modules/php/api/validation/ValidationResult.java
##########
@@ -98,6 +113,20 @@ public boolean hasWarnings() {
}
+ /**
+ * Get the first warning.
+ *
+ * @return the first warning.
Review comment:
Will fix. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#discussion_r453265442
##########
File path: php/php.api.phpmodule/src/org/netbeans/modules/php/api/validation/ValidationResult.java
##########
@@ -80,6 +81,20 @@ public boolean hasErrors() {
return new ArrayList<>(errors);
}
+ /**
+ * Get the first error.
+ *
+ * @return the first error.
+ * @since 2.72
+ */
+ @CheckForNull
+ public Message getFirstError() {
+ if (hasErrors()) {
+ return errors.get(0);
+ }
+ return null;
+ }
Review comment:
I also thought other implementations:
#### Create Message.EMPTY and return it
```java
public Message getFirstError() {
if (hasErrors()) {
return errors.get(0);
}
return Message.EMPTY;
}
public static final class Message {
public static final Message EMPTY = new Message("", "");
```
#### Use Optional
```java
public Optional<Message> getFirstError() {
if (hasErrors()) {
return Optional.of(errors.get(0));
}
return Optional.empty();
}
```
Which is better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on a change in pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#discussion_r454831171
##########
File path: php/php.api.phpmodule/src/org/netbeans/modules/php/api/validation/ValidationResult.java
##########
@@ -80,6 +81,20 @@ public boolean hasErrors() {
return new ArrayList<>(errors);
}
+ /**
+ * Get the first error.
+ *
+ * @return the first error.
+ * @since 2.72
+ */
+ @CheckForNull
+ public Message getFirstError() {
+ if (hasErrors()) {
+ return errors.get(0);
+ }
+ return null;
+ }
Review comment:
I think that `Message.EMPTY` would complicate things because the caller would need to (a) check whether it is an empty message (which is similar for the current check for `null`) or (b) adjust UI not to show the empty error as an error.
Using `Optional` would be better but I would perhaps keep the current implementation, it is more _consistent_ with the rest of the NetBeans codebase (and we have `@CheckForNull`). But up to you, feel free to use it if you want to, I definitely have no objections.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on a change in pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#discussion_r455026613
##########
File path: php/php.api.phpmodule/src/org/netbeans/modules/php/api/validation/ValidationResult.java
##########
@@ -98,6 +113,20 @@ public boolean hasWarnings() {
}
+ /**
+ * Get the first warning.
+ *
+ * @return the first warning or {@code null} if there are no errors
Review comment:
Should be `[...] no [warnings]` ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on a change in pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#discussion_r455025725
##########
File path: php/php.api.phpmodule/manifest.mf
##########
@@ -1,4 +1,4 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.php.api.phpmodule
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/php/api/phpmodule/resources/Bundle.properties
-OpenIDE-Module-Specification-Version: 2.71
+OpenIDE-Module-Specification-Version: 2.72
Review comment:
OK, so some other module has to depend on it (my bet is `php.project`). But that would mean that also version of that module (together with `php.kit`) would need to be increased - probably not needed (I have no idea how "live" NB updates are). So, let's keep it as it is, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on a change in pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#discussion_r454832469
##########
File path: php/php.api.phpmodule/src/org/netbeans/modules/php/api/validation/ValidationResult.java
##########
@@ -80,6 +81,20 @@ public boolean hasErrors() {
return new ArrayList<>(errors);
}
+ /**
+ * Get the first error.
+ *
+ * @return the first error.
Review comment:
Maybe to be added `or {@code null} if there are no errors`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2250: Minor improvements for php.api.phpmodule
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2250:
URL: https://github.com/apache/netbeans/pull/2250#issuecomment-658724116
@tmysik Thanks a lot for your review and your time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists