[GitHub] [flink] zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero

[GitBox <gi...@apache.org>]

zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r402795100
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/Buffer.java
 ##########
 @@ -55,9 +57,9 @@
 	boolean isBuffer();
 
 	/**
-	 * Tags this buffer to represent an event.
+	 * Tags this buffer to represent an event of the given type.
 	 */
-	void tagAsEvent();
+	void tagAsEvent(DataType dataType);
 
 Review comment:
   It seems not clear whether the passed `dataType` must be an event type or not. So the method naming with argument seems not consistent, i prefer to naming the method as `tagBufferType`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services