[GitHub] [httpcomponents-client] ok2c commented on a change in pull request #324: Fix typo method and class. Deprecate the old ones.

[GitBox <gi...@apache.org>]

ok2c commented on a change in pull request #324:
URL: https://github.com/apache/httpcomponents-client/pull/324#discussion_r747516952



##########
File path: httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CacheUpdateHandler.java
##########
@@ -65,6 +65,25 @@
     /**
      * Creates a cache entry for the given request, origin response message and response content.
      */
+    public HttpCacheEntry createCacheEntry(

Review comment:
       @arturobernalg `CacheUpdateHandler` is not a part of public API. Deprecation is not needed  here.

##########
File path: httpclient5/src/main/java/org/apache/hc/client5/http/async/methods/IgnoreCompleteExceptonFutureCallback.java
##########
@@ -30,6 +30,11 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+/**

Review comment:
       @arturobernalg Please make this class extend `IgnoreCompleteExceptionFutureCallback`.

##########
File path: httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CachingExecBase.java
##########
@@ -139,6 +139,23 @@ public long getCacheUpdates() {
         return cacheUpdates.get();
     }
 
+    /**

Review comment:
       @arturobernalg Same here. This is not a public method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org