You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by jm...@apache.org on 2005/06/01 06:30:31 UTC

svn commit: r179354 - /spamassassin/trunk/sa-learn.raw /spamassassin/trunk/spamassassin.raw

Author: jm
Date: Tue May 31 21:30:30 2005
New Revision: 179354

URL: http://svn.apache.org/viewcvs?rev=179354&view=rev
Log:
bug 4363: use binmode() on STDIN and STDOUT to get correct behaviour with 8-bit messages on ActivePerl

Modified:
    spamassassin/trunk/sa-learn.raw
    spamassassin/trunk/spamassassin.raw

Modified: spamassassin/trunk/sa-learn.raw
URL: http://svn.apache.org/viewcvs/spamassassin/trunk/sa-learn.raw?rev=179354&r1=179353&r2=179354&view=diff
==============================================================================
--- spamassassin/trunk/sa-learn.raw (original)
+++ spamassassin/trunk/sa-learn.raw Tue May 31 21:30:30 2005
@@ -212,6 +212,11 @@
 
 $spamtest->init(1);
 
+if (Mail::SpamAssassin::Util::am_running_on_windows()) {
+  binmode(STDIN);       # bug 4363
+  binmode(STDOUT);
+}
+
 # kluge to support old check_bayes_db operation
 if ( defined $bayes_override_path ) {
 

Modified: spamassassin/trunk/spamassassin.raw
URL: http://svn.apache.org/viewcvs/spamassassin/trunk/spamassassin.raw?rev=179354&r1=179353&r2=179354&view=diff
==============================================================================
--- spamassassin/trunk/spamassassin.raw (original)
+++ spamassassin/trunk/spamassassin.raw Tue May 31 21:30:30 2005
@@ -225,6 +225,11 @@
   $opt{'debug'} ||= 'all';
 }
 
+if (Mail::SpamAssassin::Util::am_running_on_windows()) {
+  binmode(STDIN);       # bug 4363
+  binmode(STDOUT);
+}
+
 # create the tester factory
 my $spamtest = new Mail::SpamAssassin(
   {



Re: svn commit: r179354 - /spamassassin/trunk/sa-learn.raw /spamassassin/trunk/spamassassin.raw

Posted by Theo Van Dinter <fe...@kluge.net>.
On Wed, Jun 01, 2005 at 04:30:31AM -0000, jm@apache.org wrote:
> +if (Mail::SpamAssassin::Util::am_running_on_windows()) {
> +  binmode(STDIN);       # bug 4363
> +  binmode(STDOUT);
> +}

Since this is the default on UNIX anyway, should we bother with the if() ?

-- 
Randomly Generated Tagline:
When the chips are down, the buffalo's empty.