You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@santuario.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2018/06/06 19:31:29 UTC
[VOTE] - Release Apache Santuario - XML Security for Java 2.0.11
(take II)
This is a vote to release Apache Santuario - XML Security for Java 2.0.11.
Issues fixed:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311231&version=12342673
SVN tag:
https://svn.apache.org/repos/asf/santuario/xml-security-java/tags/xmlsec-2.0.11/
Artifacts:
https://repository.apache.org/content/repositories/orgapachesantuario-1021/
+1 from me.
Colm.
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
Re: [VOTE] - Release Apache Santuario - XML Security for Java 2.0.11
(take II)
Posted by Colm O hEigeartaigh <co...@apache.org>.
Yes, the DocumentBuilder pool has been replaced by the ThreadLocal patch
attached to SANTUARIO-394. I'll reply to the private list with more
information.
Colm.
On Wed, Jun 6, 2018 at 11:26 PM, Brent Putman <pu...@georgetown.edu>
wrote:
>
>
> On 6/6/18 3:55 PM, Cantor, Scott wrote:
>
> Colm, I got a little spooked by all those commits and reverts, can you clarify exactly what the "fix" was and what portions of the code were impacted?
>
>
>
> Specifically, amongst the other changes, it appears that something similar
> to the proposed patch of SANTUARIO-394 has been introduced, using
> ThreadLocal to cache DocumentBuilder instances. In the issue discussion
> seems like that approach was frowned upon and rejected back in 2014. Can
> you clarify what's going on there, and why?
>
> Thanks,
> Brent
>
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
Re: [VOTE] - Release Apache Santuario - XML Security for Java 2.0.11
(take II)
Posted by Brent Putman <pu...@georgetown.edu>.
On 6/6/18 3:55 PM, Cantor, Scott wrote:
> Colm, I got a little spooked by all those commits and reverts, can you clarify exactly what the "fix" was and what portions of the code were impacted?
>
Specifically, amongst the other changes, it appears that something
similar to the proposed patch of SANTUARIO-394 has been introduced,
using ThreadLocal to cache DocumentBuilder instances. In the issue
discussion seems like that approach was frowned upon and rejected back
in 2014. Can you clarify what's going on there, and why?
Thanks,
Brent
RE: [VOTE] - Release Apache Santuario - XML Security for Java 2.0.11
(take II)
Posted by "Cantor, Scott" <ca...@osu.edu>.
Colm, I got a little spooked by all those commits and reverts, can you clarify exactly what the "fix" was and what portions of the code were impacted?
-- Scott
RE: [VOTE] - Release Apache Santuario - XML Security for Java 2.0.11
(take II)
Posted by "Cantor, Scott" <ca...@osu.edu>.
I'm rescinding my +1 vote and voting -1, as I have identified a breaking change in the ThreadLocal approach.
-- Scott
> -----Original Message-----
> From: Cantor, Scott
> Sent: Thursday, June 7, 2018 11:25 AM
> To: dev@santuario.apache.org; coheigea@apache.org
> Subject: RE: [VOTE] - Release Apache Santuario - XML Security for Java 2.0.11
> (take II)
>
> > This is a vote to release Apache Santuario - XML Security for Java 2.0.11.
>
> +1
RE: [VOTE] - Release Apache Santuario - XML Security for Java 2.0.11
(take II)
Posted by "Cantor, Scott" <ca...@osu.edu>.
> This is a vote to release Apache Santuario - XML Security for Java 2.0.11.
+1
I would like to request that an issue be opened to work on a longer term fix that will implement the API changes needed so that the library isn't requesting DocumentBuilder instances, but just calling an API to parse or create documents. I believe that will address a number of concerns that have been raised internally.
-- Scott
Re: [VOTE] - Release Apache Santuario - XML Security for Java 2.0.11
(take II)
Posted by Alessio Soldano <as...@apache.org>.
+1
Thanks
On Wed, Jun 6, 2018 at 9:31 PM, Colm O hEigeartaigh <co...@apache.org>
wrote:
> This is a vote to release Apache Santuario - XML Security for Java 2.0.11.
>
> Issues fixed:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12311231&version=12342673
>
> SVN tag:
>
> https://svn.apache.org/repos/asf/santuario/xml-security-
> java/tags/xmlsec-2.0.11/
>
> Artifacts:
>
> https://repository.apache.org/content/repositories/
> orgapachesantuario-1021/
>
> +1 from me.
>
> Colm.
>
>
> --
> Colm O hEigeartaigh
>
> Talend Community Coder
> http://coders.talend.com
>