[GitHub] [superset] nytai commented on a diff in pull request #21065: fix(databases): GSheets and Clickhouse DBs are not allowed to upload files

[GitBox <gi...@apache.org>]

nytai commented on code in PR #21065:
URL: https://github.com/apache/superset/pull/21065#discussion_r945410290


##########
superset/views/database/forms.py:
##########
@@ -39,6 +40,12 @@
 )
 from superset.models.core import Database
 
+
+class DatabasesNotAllowedToFileUpload(str, Enum):
+    GSHEETS = "gsheets"
+    CLICKHOUSE = "clickhousedb"

Review Comment:
   Rather than maintaining a separate enum for this, why not define this as a property on the db_engine_spec?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org