[jira] Commented: (HADOOP-6164) Test-patch's method of checking for new tests is not correct

["Giridharan Kesavan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734003#action_12734003 ] 

Giridharan Kesavan commented on HADOOP-6164:
--------------------------------------------

test patch doesn make any decision on the no of tests run. If the tests fail it fails the build. It is hudson which parses the junit test results from the xml file.

BTW hudson didnt run any core-test for HDFS-450
it failed for create-configure-c++ so didnt run test-core target
so -1 for core test
and hdfsproxy test failed so -1 for contrib test.

test-patch script doesnt do any count on the no of test run.



> Test-patch's method of checking for new tests is not correct
> ------------------------------------------------------------
>
>                 Key: HADOOP-6164
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6164
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>            Reporter: Jakob Homan
>
> As happened in HDFS-458, test-patch/hudson saw the previous patch(HDFS-492) add a new test, bringing the total number of tests to 49.  Then it tested 458, which had no new tests as it was a change to the build file.  492 had not yet been committed yet, so there were still only 48 tests in trunk.  But test-patch failed the patch, expecting 49 tests.  test-patch should check the correct number of tests based on trunk, not on whatever number it last saw.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.