[GitHub] [airflow] OmerJog commented on issue #5288: AIRFLOW-4512 - New trigger rule for tasks - At least one successful

[GitBox <gi...@apache.org>]

OmerJog commented on issue #5288: AIRFLOW-4512 - New trigger rule for tasks - At least one successful
URL: https://github.com/apache/airflow/pull/5288#issuecomment-493751883
 
 
   This PR is missing tests.
   You can refer to another PR which added new trigger rule for reference https://github.com/apache/airflow/pull/5032
   
   Also I'm not too crazy about the name `ATLEAST_ONE_SUCCESS`.
   The name should reflect the meaning. When viewing `ONE_SUCCESS `and `ATLEAST_ONE_SUCCESS `it will causes confusion between them.
   
   As a general comment if this is merged it will open a window to many many different kinds of trigger rules. Maybe a better approach will be to design a mechanism where you can use more than one trigger rule. So for your need it will be `ALL_DONE `+ `ONE_SUCCESS`. This way there will be less trigger rules to maintain and the functionality will grow dramatically. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services