[GitHub] [arrow] jonkeane commented on a diff in pull request #13086: ARROW-16414: [R] Remove ARROW_R_WITH_ARROW and arrow_available()

[GitBox <gi...@apache.org>]

jonkeane commented on code in PR #13086:
URL: https://github.com/apache/arrow/pull/13086#discussion_r867257196


##########
r/R/arrow-package.R:
##########
@@ -80,90 +78,29 @@
     }
   }
 
-  if (arrow_available()) {
-    # register extension types that we use internally
-    reregister_extension_type(vctrs_extension_type(vctrs::unspecified()))
-  }
+  # register extension types that we use internally
+  reregister_extension_type(vctrs_extension_type(vctrs::unspecified()))
 
   invisible()
 }
 
 .onAttach <- function(libname, pkgname) {
-  if (!arrow_available()) {
-    msg <- paste(
-      "The Arrow C++ library is not available. To retry installation with debug output, run:",
-      "    install_arrow(verbose = TRUE)",
-      "See https://arrow.apache.org/docs/r/articles/install.html for more guidance and troubleshooting.",
-      sep = "\n"
-    )
-    packageStartupMessage(msg)
-  } else {
-    # Just to be extra safe, let's wrap this in a try();
-    # we don't a failed startup message to prevent the package from loading
-    try({
-      features <- arrow_info()$capabilities
-      # That has all of the #ifdef features, plus the compression libs and the
-      # string libraries (but not the memory allocators, they're added elsewhere)
-      #
-      # Let's print a message if some are off
-      if (some_features_are_off(features)) {
-        packageStartupMessage(
-          paste(
-            "Some features are not enabled in this build of Arrow.",
-            "Run `arrow_info()` for more information."
-          )
+  # Just to be extra safe, let's wrap this in a try();
+  # we don't a failed startup message to prevent the package from loading

Review Comment:
   ```suggestion
     # we don't want a failed startup message to prevent the package from loading
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org