You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/27 08:12:33 UTC

[GitHub] [flink] twalthr opened a new pull request #18529: [FLINK-25826][table-planner] Handle symbols at a central place with serializable format

twalthr opened a new pull request #18529:
URL: https://github.com/apache/flink/pull/18529


   ## What is the purpose of the change
   
   The Table API, `table-common` and planner declare several symbols that basically describe the same thing. However, their is not straightforward and should only consistently exposed via the persisted JSON plan. This introduces a central utility to ease the handling of those symbols. Not nice but it serves the purpose.
   
   
   ## Brief change log
   
   - Introduce `SymbolUtil`
   - Add mapping for all symbols that end up in a plan
   - Remove custom mappings at various locations
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows: `SymbolUtilTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? JavaDocs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18529: [FLINK-25826][table-planner] Handle symbols at a central place with serializable format

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18529:
URL: https://github.com/apache/flink/pull/18529#issuecomment-1022956743


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7a905fd10f7037b2cbf6d30c16d87097eba03b7c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7a905fd10f7037b2cbf6d30c16d87097eba03b7c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7a905fd10f7037b2cbf6d30c16d87097eba03b7c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr closed pull request #18529: [FLINK-25826][table-planner] Handle symbols at a central place with serializable format

Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #18529:
URL: https://github.com/apache/flink/pull/18529


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18529: [FLINK-25826][table-planner] Handle symbols at a central place with serializable format

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18529:
URL: https://github.com/apache/flink/pull/18529#issuecomment-1022954360


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 010a86c2f98fc5ae2b79973b8fca15427b4092d2 (Thu Jan 27 08:15:46 UTC 2022)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18529: [FLINK-25826][table-planner] Handle symbols at a central place with serializable format

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18529:
URL: https://github.com/apache/flink/pull/18529#issuecomment-1022956743


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7a905fd10f7037b2cbf6d30c16d87097eba03b7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30279",
       "triggerID" : "7a905fd10f7037b2cbf6d30c16d87097eba03b7c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7a905fd10f7037b2cbf6d30c16d87097eba03b7c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30279) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18529: [FLINK-25826][table-planner] Handle symbols at a central place with serializable format

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18529:
URL: https://github.com/apache/flink/pull/18529#issuecomment-1022956743


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "010a86c2f98fc5ae2b79973b8fca15427b4092d2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "010a86c2f98fc5ae2b79973b8fca15427b4092d2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 010a86c2f98fc5ae2b79973b8fca15427b4092d2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18529: [FLINK-25826][table-planner] Handle symbols at a central place with serializable format

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18529:
URL: https://github.com/apache/flink/pull/18529#issuecomment-1022956743


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7a905fd10f7037b2cbf6d30c16d87097eba03b7c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30279",
       "triggerID" : "7a905fd10f7037b2cbf6d30c16d87097eba03b7c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7a905fd10f7037b2cbf6d30c16d87097eba03b7c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30279) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org