You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/11 18:03:07 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #2203: Remove tokio::spawn from WindowAggExec (#2201)
tustvold opened a new pull request, #2203:
URL: https://github.com/apache/arrow-datafusion/pull/2203
# Which issue does this PR close?
Part of https://github.com/apache/arrow-datafusion/issues/2201.
# Rationale for this change
See ticket
# What changes are included in this PR?
This removes the tokio::spawn from WindowAggExec. I opted to just remove the spawn, instead of making it conditional on being run in a tokio runtime, as I'm not actually sure why it does this? I guess it might allow for parallelism with respect to parent operators, but it seems a little unusual for an operator to make this distinction?
# Are there any user-facing changes?
WindowAggExec can be used outside a tokio runtime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2203: Remove tokio::spawn from WindowAggExec (#2201)
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2203:
URL: https://github.com/apache/arrow-datafusion/pull/2203#discussion_r849766944
##########
datafusion/core/src/physical_plan/windows/window_agg_exec.rs:
##########
@@ -232,16 +230,14 @@ fn compute_window_aggregates(
.collect()
}
-pin_project! {
Review Comment:
Turns out cargo culting was copying bad habits around. 👍 for cleaning this up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen commented on a diff in pull request #2203: Remove tokio::spawn from WindowAggExec (#2201)
Posted by GitBox <gi...@apache.org>.
yjshen commented on code in PR #2203:
URL: https://github.com/apache/arrow-datafusion/pull/2203#discussion_r847880589
##########
datafusion/core/src/physical_plan/windows/window_agg_exec.rs:
##########
@@ -232,16 +230,14 @@ fn compute_window_aggregates(
.collect()
}
-pin_project! {
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 merged pull request #2203: Remove tokio::spawn from WindowAggExec (#2201)
Posted by GitBox <gi...@apache.org>.
xudong963 merged PR #2203:
URL: https://github.com/apache/arrow-datafusion/pull/2203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org