You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2018/05/10 02:15:06 UTC

[1/5] hbase git commit: HBASE-20554 "WALs outstanding" message from CleanerChore is noisy

Repository: hbase
Updated Branches:
  refs/heads/branch-1 5406f6333 -> c191462ac
  refs/heads/branch-1.4 288e1191f -> dc7b33eb6
  refs/heads/branch-2 cba8d2fb8 -> c430016cf
  refs/heads/branch-2.0 ce72f9d13 -> 4ac2e171c
  refs/heads/master 9c046c091 -> 32dd633b9


HBASE-20554 "WALs outstanding" message from CleanerChore is noisy


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/32dd633b
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/32dd633b
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/32dd633b

Branch: refs/heads/master
Commit: 32dd633b9899a2cae70c017c33a616701d6cf7bc
Parents: 9c046c0
Author: Andrew Purtell <ap...@apache.org>
Authored: Wed May 9 10:16:44 2018 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Wed May 9 19:08:35 2018 -0700

----------------------------------------------------------------------
 .../hadoop/hbase/master/cleaner/CleanerChore.java       | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/32dd633b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
index dc13645..bcb23ac 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
@@ -272,9 +272,13 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
       try {
         POOL.latchCountUp();
         if (runCleaner()) {
-          LOG.debug("Cleaned all WALs under {}", oldFileDir);
+          if (LOG.isTraceEnabled()) {
+            LOG.trace("Cleaned all WALs under {}", oldFileDir);
+          }
         } else {
-          LOG.warn("WALs outstanding under {}", oldFileDir);
+          if (LOG.isTraceEnabled()) {
+            LOG.trace("WALs outstanding under {}", oldFileDir);
+          }
         }
       } finally {
         POOL.latchCountDown();
@@ -287,7 +291,9 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
         POOL.updatePool((long) (0.8 * getTimeUnit().toMillis(getPeriod())));
       }
     } else {
-      LOG.debug("Cleaner chore disabled! Not cleaning.");
+      if (LOG.isTraceEnabled()) {
+        LOG.trace("Cleaner chore disabled! Not cleaning.");
+      }
     }
   }
 


[2/5] hbase git commit: HBASE-20554 "WALs outstanding" message from CleanerChore is noisy

Posted by ap...@apache.org.
HBASE-20554 "WALs outstanding" message from CleanerChore is noisy


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/4ac2e171
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/4ac2e171
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/4ac2e171

Branch: refs/heads/branch-2.0
Commit: 4ac2e171c833335802c4f49d9d0c6e69fcff1414
Parents: ce72f9d
Author: Andrew Purtell <ap...@apache.org>
Authored: Wed May 9 10:16:44 2018 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Wed May 9 19:10:05 2018 -0700

----------------------------------------------------------------------
 .../hadoop/hbase/master/cleaner/CleanerChore.java       | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/4ac2e171/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
index 8765a43..a003c6b 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
@@ -223,16 +223,22 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
   protected void chore() {
     if (getEnabled()) {
       if (runCleaner()) {
-        LOG.debug("Cleaned all WALs under {}",  oldFileDir);
+        if (LOG.isTraceEnabled()) {
+          LOG.trace("Cleaned all WALs under {}", oldFileDir);
+        }
       } else {
-        LOG.warn("WALs outstanding under {}", oldFileDir);
+        if (LOG.isTraceEnabled()) {
+          LOG.trace("WALs outstanding under {}", oldFileDir);
+        }
       }
       // After each clean chore, checks if receives reconfigure notification while cleaning
       if (reconfig.compareAndSet(true, false)) {
         updateChorePoolSize(CHOREPOOLSIZE);
       }
     } else {
-      LOG.debug("Cleaner chore disabled! Not cleaning.");
+      if (LOG.isTraceEnabled()) {
+        LOG.trace("Cleaner chore disabled! Not cleaning.");
+      }
     }
   }
 


[3/5] hbase git commit: HBASE-20554 "WALs outstanding" message from CleanerChore is noisy

Posted by ap...@apache.org.
HBASE-20554 "WALs outstanding" message from CleanerChore is noisy


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/c430016c
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/c430016c
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/c430016c

Branch: refs/heads/branch-2
Commit: c430016cf95dfe5c47d2b4c722cc892da2b4a60f
Parents: cba8d2f
Author: Andrew Purtell <ap...@apache.org>
Authored: Wed May 9 10:16:44 2018 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Wed May 9 19:11:50 2018 -0700

----------------------------------------------------------------------
 .../hadoop/hbase/master/cleaner/CleanerChore.java       | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/c430016c/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
index dc13645..bcb23ac 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
@@ -272,9 +272,13 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
       try {
         POOL.latchCountUp();
         if (runCleaner()) {
-          LOG.debug("Cleaned all WALs under {}", oldFileDir);
+          if (LOG.isTraceEnabled()) {
+            LOG.trace("Cleaned all WALs under {}", oldFileDir);
+          }
         } else {
-          LOG.warn("WALs outstanding under {}", oldFileDir);
+          if (LOG.isTraceEnabled()) {
+            LOG.trace("WALs outstanding under {}", oldFileDir);
+          }
         }
       } finally {
         POOL.latchCountDown();
@@ -287,7 +291,9 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
         POOL.updatePool((long) (0.8 * getTimeUnit().toMillis(getPeriod())));
       }
     } else {
-      LOG.debug("Cleaner chore disabled! Not cleaning.");
+      if (LOG.isTraceEnabled()) {
+        LOG.trace("Cleaner chore disabled! Not cleaning.");
+      }
     }
   }
 


[4/5] hbase git commit: HBASE-20554 "WALs outstanding" message from CleanerChore is noisy

Posted by ap...@apache.org.
HBASE-20554 "WALs outstanding" message from CleanerChore is noisy


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/c191462a
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/c191462a
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/c191462a

Branch: refs/heads/branch-1
Commit: c191462ac35461c6c592a3d7ab2328b88963b461
Parents: 5406f63
Author: Andrew Purtell <ap...@apache.org>
Authored: Wed May 9 10:16:44 2018 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Wed May 9 19:13:17 2018 -0700

----------------------------------------------------------------------
 .../hadoop/hbase/master/cleaner/CleanerChore.java       | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/c191462a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
index ea18193..f073d30 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
@@ -263,9 +263,13 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
       try {
         POOL.latchCountUp();
         if (runCleaner()) {
-          LOG.debug("Cleaned all WALs under " + oldFileDir);
+          if (LOG.isTraceEnabled()) {
+            LOG.trace("Cleaned all WALs under " + oldFileDir);
+          }
         } else {
-          LOG.warn("WALs outstanding under " + oldFileDir);
+          if (LOG.isTraceEnabled()) {
+            LOG.trace("WALs outstanding under " + oldFileDir);
+          }
         }
       } finally {
         POOL.latchCountDown();
@@ -278,7 +282,9 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
         POOL.updatePool((long) (0.8 * getTimeUnit().toMillis(getPeriod())));
       }
     } else {
-      LOG.debug("Cleaner chore disabled! Not cleaning.");
+      if (LOG.isTraceEnabled()) {
+        LOG.trace("Cleaner chore disabled! Not cleaning.");
+      }
     }
   }
 


[5/5] hbase git commit: HBASE-20554 "WALs outstanding" message from CleanerChore is noisy

Posted by ap...@apache.org.
HBASE-20554 "WALs outstanding" message from CleanerChore is noisy


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/dc7b33eb
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/dc7b33eb
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/dc7b33eb

Branch: refs/heads/branch-1.4
Commit: dc7b33eb681d4bde8703d443bb9f6b84ba6780db
Parents: 288e119
Author: Andrew Purtell <ap...@apache.org>
Authored: Wed May 9 10:16:44 2018 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Wed May 9 19:13:24 2018 -0700

----------------------------------------------------------------------
 .../hadoop/hbase/master/cleaner/CleanerChore.java       | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/dc7b33eb/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
index ea18193..f073d30 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
@@ -263,9 +263,13 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
       try {
         POOL.latchCountUp();
         if (runCleaner()) {
-          LOG.debug("Cleaned all WALs under " + oldFileDir);
+          if (LOG.isTraceEnabled()) {
+            LOG.trace("Cleaned all WALs under " + oldFileDir);
+          }
         } else {
-          LOG.warn("WALs outstanding under " + oldFileDir);
+          if (LOG.isTraceEnabled()) {
+            LOG.trace("WALs outstanding under " + oldFileDir);
+          }
         }
       } finally {
         POOL.latchCountDown();
@@ -278,7 +282,9 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
         POOL.updatePool((long) (0.8 * getTimeUnit().toMillis(getPeriod())));
       }
     } else {
-      LOG.debug("Cleaner chore disabled! Not cleaning.");
+      if (LOG.isTraceEnabled()) {
+        LOG.trace("Cleaner chore disabled! Not cleaning.");
+      }
     }
   }