You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Gary Tully (JIRA)" <ji...@apache.org> on 2016/08/08 10:01:20 UTC

[jira] [Commented] (AMQ-6388) activemq-client/src/main/java/org/apache/activemq/util/URISupport.java

    [ https://issues.apache.org/jira/browse/AMQ-6388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411611#comment-15411611 ] 

Gary Tully commented on AMQ-6388:
---------------------------------

please write a little unit test to prove this out. It will also protect any fix into the future.
some inspiration at: https://github.com/apache/activemq/blob/e2b4ca2c59a316be91cf391c758a10e518dd3a1f/activemq-client/src/test/java/org/apache/activemq/util/URISupportTest.java

> activemq-client/src/main/java/org/apache/activemq/util/URISupport.java
> ----------------------------------------------------------------------
>
>                 Key: AMQ-6388
>                 URL: https://issues.apache.org/jira/browse/AMQ-6388
>             Project: ActiveMQ
>          Issue Type: Bug
>            Reporter: liuzq
>
> when I study the java code of ActiveMQ 5.13.4,
> I find the code of(https://github.com/apache/activemq/blob/master/activemq-client/src/main/java/org/apache/activemq/util/URISupport.java)
> maybe there is a bug with (line 368):---> if (initialParen == 0) {
> I think the code here should be if (initialParen >=0) {



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)