You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/08 20:32:40 UTC
[GitHub] [doris] xinyiZzz opened a new pull request, #15716: [enhancement](memtracker) Hide inaccurate mem tracker
xinyiZzz opened a new pull request, #15716:
URL: https://github.com/apache/doris/pull/15716
# Proposed changes
Issue Number: close #xxx
## Problem summary
The mem tracker using mem hook statistics cannot guarantee the accuracy, because the memory transfer between function cannot be enumerated.
This is often misleading in real production environments, so these inaccurate mem trackers are only printed when `memory_debug=true`.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15716: [enhancement](memtracker) Hide inaccurate mem tracker
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15716:
URL: https://github.com/apache/doris/pull/15716#issuecomment-1374930938
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.13 seconds
load time: 482 seconds
storage size: 17122296201 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230108212531_clickbench_pr_75745.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #15716: [enhancement](memtracker) Improve readability
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #15716:
URL: https://github.com/apache/doris/pull/15716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15716: [enhancement](memtracker) Improve readability
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15716:
URL: https://github.com/apache/doris/pull/15716#issuecomment-1383409069
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15716: [enhancement](memtracker) Improve readability
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15716:
URL: https://github.com/apache/doris/pull/15716#issuecomment-1383202761
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15716: [enhancement](memtracker) Improve readability
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15716:
URL: https://github.com/apache/doris/pull/15716#issuecomment-1377100721
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15716: [enhancement](memtracker) Improve readability
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15716:
URL: https://github.com/apache/doris/pull/15716#issuecomment-1376830472
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15716: [enhancement](memtracker) Improve readability
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15716:
URL: https://github.com/apache/doris/pull/15716#issuecomment-1377100663
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15716: [enhancement](memtracker) Hide inaccurate mem tracker
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15716:
URL: https://github.com/apache/doris/pull/15716#issuecomment-1376783938
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #15716: [enhancement](memtracker) Improve readability
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #15716:
URL: https://github.com/apache/doris/pull/15716#discussion_r1065646206
##########
be/src/olap/push_handler.cpp:
##########
@@ -829,8 +829,8 @@ Status PushBrokerReader::init(const Schema* schema, const TBrokerScanRange& t_sc
}
_runtime_profile = _runtime_state->runtime_profile();
_runtime_profile->set_name("PushBrokerReader");
- _mem_pool.reset(new MemPool(_runtime_state->scanner_mem_tracker().get()));
Review Comment:
Using load memtracker here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15716: [enhancement](memtracker) Hide inaccurate mem tracker
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15716:
URL: https://github.com/apache/doris/pull/15716#issuecomment-1374923631
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15716: [enhancement](memtracker) Improve readability
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15716:
URL: https://github.com/apache/doris/pull/15716#issuecomment-1383355085
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15716: [enhancement](memtracker) Improve readability
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15716:
URL: https://github.com/apache/doris/pull/15716#issuecomment-1383401835
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on a diff in pull request #15716: [enhancement](memtracker) Improve readability
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on code in PR #15716:
URL: https://github.com/apache/doris/pull/15716#discussion_r1066500857
##########
be/src/olap/push_handler.cpp:
##########
@@ -829,8 +829,8 @@ Status PushBrokerReader::init(const Schema* schema, const TBrokerScanRange& t_sc
}
_runtime_profile = _runtime_state->runtime_profile();
_runtime_profile->set_name("PushBrokerReader");
- _mem_pool.reset(new MemPool(_runtime_state->scanner_mem_tracker().get()));
Review Comment:
It has been recorded in batch load thread mem tracker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15716: [enhancement](memtracker) Improve readability
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15716:
URL: https://github.com/apache/doris/pull/15716#issuecomment-1378150961
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org