You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dlab.apache.org by an...@apache.org on 2019/10/01 10:08:48 UTC

[incubator-dlab] 05/08: [DLAB-1141]: changed cluster name limits

This is an automated email from the ASF dual-hosted git repository.

ankovalyshyn pushed a commit to branch DLAB-terraform
in repository https://gitbox.apache.org/repos/asf/incubator-dlab.git

commit f466977c6696d7ea89b8160d8f1cb49761824dbb
Author: Andriana Kovalyshyn <An...@epam.com>
AuthorDate: Tue Oct 1 13:04:11 2019 +0300

    [DLAB-1141]: changed cluster name limits
---
 .../computational-resource-create-dialog.component.ts                   | 2 +-
 .../src/main/resources/webapp/src/dictionary/aws.dictionary.ts          | 1 +
 .../src/main/resources/webapp/src/dictionary/azure.dictionary.ts        | 1 +
 .../src/main/resources/webapp/src/dictionary/gcp.dictionary.ts          | 1 +
 4 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/computational/computational-resource-create-dialog/computational-resource-create-dialog.component.ts b/services/self-service/src/main/resources/webapp/src/app/resources/computational/computational-resource-create-dialog/computational-resource-create-dialog.component.ts
index df58386..bcb5d61 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/computational/computational-resource-create-dialog/computational-resource-create-dialog.component.ts
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/computational/computational-resource-create-dialog/computational-resource-create-dialog.component.ts
@@ -234,7 +234,7 @@ export class ComputationalResourceCreateDialogComponent implements OnInit {
 
   private providerMaxLength(control) {
     if (DICTIONARY.cloud_provider !== 'aws')
-      return control.value.length <= 10 ? null : { valid: false };
+      return control.value.length <= DICTIONARY.max_cluster_name_length ? null : { valid: false };
   }
 
   private getTemplates(project, endpoint) {
diff --git a/services/self-service/src/main/resources/webapp/src/dictionary/aws.dictionary.ts b/services/self-service/src/main/resources/webapp/src/dictionary/aws.dictionary.ts
index cf27936..fd767e7 100644
--- a/services/self-service/src/main/resources/webapp/src/dictionary/aws.dictionary.ts
+++ b/services/self-service/src/main/resources/webapp/src/dictionary/aws.dictionary.ts
@@ -34,6 +34,7 @@ export const NAMING_CONVENTION = {
     'total_instance_number': 'total_instance_number',
     'spot_instance': 'Spot instance',
     'cluster_version': 'emr_version',
+    'max_cluster_name_length': 64,
     'billing': {
         'resourceName': 'resource_name',
         'cost': 'cost',
diff --git a/services/self-service/src/main/resources/webapp/src/dictionary/azure.dictionary.ts b/services/self-service/src/main/resources/webapp/src/dictionary/azure.dictionary.ts
index b8779b6..fd178c5 100644
--- a/services/self-service/src/main/resources/webapp/src/dictionary/azure.dictionary.ts
+++ b/services/self-service/src/main/resources/webapp/src/dictionary/azure.dictionary.ts
@@ -35,6 +35,7 @@ export const NAMING_CONVENTION = {
 
     'spot_instance': 'Low-priority virtual machines',
     'cluster_version': '',
+    'max_cluster_name_length': 10,
     'billing': {
         'resourceName': 'resourceName',
         'cost': 'costString',
diff --git a/services/self-service/src/main/resources/webapp/src/dictionary/gcp.dictionary.ts b/services/self-service/src/main/resources/webapp/src/dictionary/gcp.dictionary.ts
index b5a928c..3d6f26e 100644
--- a/services/self-service/src/main/resources/webapp/src/dictionary/gcp.dictionary.ts
+++ b/services/self-service/src/main/resources/webapp/src/dictionary/gcp.dictionary.ts
@@ -36,6 +36,7 @@ export const NAMING_CONVENTION = {
 
     'spot_instance': 'Preemptible worker nodes',
     'cluster_version': 'dataproc_version',
+    'max_cluster_name_length': 9,
     'billing': {
         'resourceName': 'resource_name',
         'cost': 'cost',


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@dlab.apache.org
For additional commands, e-mail: commits-help@dlab.apache.org