You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/12/17 11:39:46 UTC
[GitHub] [maven-surefire] eolivelli commented on a change in pull request
#253: Fixes [SUREFIRE-1516]: Poor performance in reuseForks=false
eolivelli commented on a change in pull request #253: Fixes [SUREFIRE-1516]: Poor performance in reuseForks=false
URL: https://github.com/apache/maven-surefire/pull/253#discussion_r358743737
##########
File path: surefire-api/src/main/java/org/apache/maven/surefire/booter/CommandReader.java
##########
@@ -412,6 +412,10 @@ public void run()
CommandReader.this.wakeupIterator();
callListeners( command );
break;
+ case BYE_ACK:
+ //After SHUTDOWN no more commands can come. Hence, do NOT go back to blocking in IO
+ callListeners( command );
+ return;
default:
callListeners( command );
Review comment:
Yes, I came to this same conclusion, change the state to TERMINATED.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services