You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by traflm <gi...@git.apache.org> on 2018/05/08 04:04:27 UTC
[GitHub] trafodion pull request #1553: [TRAFODION-1861] Run Trafodion on CentOS 7
GitHub user traflm opened a pull request:
https://github.com/apache/trafodion/pull/1553
[TRAFODION-1861] Run Trafodion on CentOS 7
Solve the link issue when using GCC 4.8 on CentOS 7
So Trafodion can start on CentOS 7 with this change
It also depends on https://github.com/apache/trafodion/pull/1552 to make the code build success
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/traflm/trafodion TRAFODION-1861
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1553.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1553
----
commit 4addf763ee18eb9cb01e2bd0fecde297a60f485c
Author: LiuMing <ov...@...>
Date: 2018-05-08T04:01:46Z
[TRAFODION-1861] Run Trafodion on CentOS 7
----
---
[GitHub] trafodion pull request #1553: [TRAFODION-1861] Run Trafodion on CentOS 7
Posted by traflm <gi...@git.apache.org>.
Github user traflm commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1553#discussion_r186920564
--- Diff: core/sqf/src/seabed/src/Makefile ---
@@ -55,6 +55,16 @@ LIBSBUTIL = $(LIBEXPDIR)/libsbutil.so
LIBSQSTATESB = $(LIBEXPDIR)/libsqstatesb.so
# neet -lrt for clock_gettime
LIBSX += -lrt
+#
+# the order of these objects have to be swapped based on the GCC version
+MS_MPITMSG_O = $(OUTDIR)/mpitmsg.o \
+ $(OUTDIR)/ms.o
+ifeq ($(GCC_MAJOR_VERSION_GT_3),1)
+ifeq ($(GCC_MINOR_VERSION_GT_4),1)
--- End diff --
You are right Dave, so it should be GCC_MAJOR_VERSION_EQ_4 and GCC_MINOR_VERSION_GT_4
We don't know how GCC 5.1 behave now, so let only check GCC 4.4 vs. GCC 4.8 at present. Let me change the logic more accurate
That is, we only change the link order for GCC 4.x , where x>4
---
[GitHub] trafodion pull request #1553: [TRAFODION-1861] Run Trafodion on CentOS 7
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1553#discussion_r186829077
--- Diff: core/sqf/src/seabed/src/Makefile ---
@@ -55,6 +55,16 @@ LIBSBUTIL = $(LIBEXPDIR)/libsbutil.so
LIBSQSTATESB = $(LIBEXPDIR)/libsqstatesb.so
# neet -lrt for clock_gettime
LIBSX += -lrt
+#
+# the order of these objects have to be swapped based on the GCC version
+MS_MPITMSG_O = $(OUTDIR)/mpitmsg.o \
+ $(OUTDIR)/ms.o
+ifeq ($(GCC_MAJOR_VERSION_GT_3),1)
+ifeq ($(GCC_MINOR_VERSION_GT_4),1)
--- End diff --
I'm not sure this is what you want. For example, if there is ever a gcc version 5.1, the first "ifeq" will be true but not the second.
---
[GitHub] trafodion pull request #1553: [TRAFODION-1861] Run Trafodion on CentOS 7
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1553
---
[GitHub] trafodion pull request #1553: [TRAFODION-1861] Run Trafodion on CentOS 7
Posted by selvaganesang <gi...@git.apache.org>.
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1553#discussion_r187361126
--- Diff: core/sqf/src/seabed/src/Makefile ---
@@ -55,6 +55,16 @@ LIBSBUTIL = $(LIBEXPDIR)/libsbutil.so
LIBSQSTATESB = $(LIBEXPDIR)/libsqstatesb.so
# neet -lrt for clock_gettime
LIBSX += -lrt
+#
+# the order of these objects have to be swapped based on the GCC version
+MS_MPITMSG_O = $(OUTDIR)/mpitmsg.o \
+ $(OUTDIR)/ms.o
+ifeq ($(GCC_MAJOR_VERSION_EQ_4),1)
+ifeq ($(GCC_MINOR_VERSION_GT_4),1)
+MS_MPITMSG_O = $(OUTDIR)/ms.o \
--- End diff --
If any release above 4.4 should use this order of .sos this change won't work either. You may consider change it as follows
By default, the order should be ms.o and mpitmsg.o,
Change the order when it is less than 4.4.
---