You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/22 16:25:21 UTC

[GitHub] [hbase] virajjasani commented on a change in pull request #2118: HBASE-24758 Avoid flooding replication source RSes logs when no sinks…

virajjasani commented on a change in pull request #2118:
URL: https://github.com/apache/hbase/pull/2118#discussion_r458920644



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSinkManager.java
##########
@@ -150,9 +151,14 @@ public synchronized void reportSinkSuccess(SinkPeer sinkPeer) {
    */
   public synchronized void chooseSinks() {
     List<ServerName> slaveAddresses = endpoint.getRegionServers();

Review comment:
       Further down in `setRegionServers(fetchSlavesAddresses(this.getZkw()))`, `fetchSlavesAddresses()`is not returning null, but empty list. So maybe we can safely log warning for `if(slaveAddresses.size()==0)` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org