You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/06/09 11:51:02 UTC

[GitHub] [spark] wenxuanguan edited a comment on issue #24828: [SPARK-27983][SS] Defer the initialization of kafka producer until used

wenxuanguan edited a comment on issue #24828: [SPARK-27983][SS] Defer the initialization of kafka producer until used
URL: https://github.com/apache/spark/pull/24828#issuecomment-500205742
 
 
   > Hi, @wenxuanguan . Could you describe a little bit more about the goal of this PR in the PR description? What kind of the benefit did you achieve in your environment? Any numbers?
   
   @dongjoon-hyun Thanks for your reply.
   As the above description added, this pr avoid unnecessary operation and resource usage before  sending message, which is made when the producer is created too early. 
   Although it is not a major change, it is necessary I reckon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org