You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/22 23:39:29 UTC
Review Request 67258: Fixed flakiness for some
`AgentResourceProviderConfigApiTest` tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67258/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Greg Mann.
Repository: mesos
Description
-------
The `ROOT_Add`, `ROOT_Update` and `ROOT_Remove` tests mistakenly use
`WillOnce` to declient unwanted offers. This patch changes them to
`WillRepeatedly`.
Diffs
-----
src/tests/agent_resource_provider_config_api_tests.cpp 7d4d3b9d21c3a0c603f805f47c57a7fa67db9d08
Diff: https://reviews.apache.org/r/67258/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 67258: Fixed flakiness for some
`AgentResourceProviderConfigApiTest` tests.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67258/#review204149
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On May 22, 2018, 11:39 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67258/
> -----------------------------------------------------------
>
> (Updated May 22, 2018, 11:39 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `ROOT_Add`, `ROOT_Update` and `ROOT_Remove` tests mistakenly use
> `WillOnce` to declient unwanted offers. This patch changes them to
> `WillRepeatedly`.
>
>
> Diffs
> -----
>
> src/tests/agent_resource_provider_config_api_tests.cpp 7d4d3b9d21c3a0c603f805f47c57a7fa67db9d08
>
>
> Diff: https://reviews.apache.org/r/67258/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67258: Fixed flakiness for some
`AgentResourceProviderConfigApiTest` tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67258/#review203626
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 67224.
Failed command: `python.exe .\support\apply-reviews.py -n -r 67224`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67258
Relevant logs:
- [apply-review-67224-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67258/logs/apply-review-67224-stdout.log):
```
error: patch failed: src/resource_provider/storage/provider.cpp:3436
error: src/resource_provider/storage/provider.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On May 22, 2018, 4:39 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67258/
> -----------------------------------------------------------
>
> (Updated May 22, 2018, 4:39 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `ROOT_Add`, `ROOT_Update` and `ROOT_Remove` tests mistakenly use
> `WillOnce` to declient unwanted offers. This patch changes them to
> `WillRepeatedly`.
>
>
> Diffs
> -----
>
> src/tests/agent_resource_provider_config_api_tests.cpp 7d4d3b9d21c3a0c603f805f47c57a7fa67db9d08
>
>
> Diff: https://reviews.apache.org/r/67258/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67258: Fixed flakiness for some
`AgentResourceProviderConfigApiTest` tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67258/#review203648
-----------------------------------------------------------
Bad patch!
Reviews applied: [67258, 67257, 67256, 67255, 67224, 65666, 65665]
Failed command: python support/apply-reviews.py -n -r 67224
Error:
2018-05-23 09:21:01 URL:https://reviews.apache.org/r/67224/diff/raw/ [4553/4553] -> "67224.patch" [1]
error: patch failed: src/resource_provider/storage/provider.cpp:3436
error: src/resource_provider/storage/provider.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/22518/console
- Mesos Reviewbot
On May 22, 2018, 11:39 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67258/
> -----------------------------------------------------------
>
> (Updated May 22, 2018, 11:39 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `ROOT_Add`, `ROOT_Update` and `ROOT_Remove` tests mistakenly use
> `WillOnce` to declient unwanted offers. This patch changes them to
> `WillRepeatedly`.
>
>
> Diffs
> -----
>
> src/tests/agent_resource_provider_config_api_tests.cpp 7d4d3b9d21c3a0c603f805f47c57a7fa67db9d08
>
>
> Diff: https://reviews.apache.org/r/67258/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>