[GitHub] [rocketmq] MountainOne commented on a change in pull request #1516: [ISSUE #1515] SYNC_MASTER could be change into pipeline manner

[GitBox <gi...@apache.org>]

MountainOne commented on a change in pull request #1516: [ISSUE #1515] SYNC_MASTER could be change into pipeline manner 
URL: https://github.com/apache/rocketmq/pull/1516#discussion_r342965251
 
 

 ##########
 File path: broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
 ##########
 @@ -215,40 +213,103 @@ private RemotingCommand consumerSendMsgBack(final ChannelHandlerContext ctx, fin
         msgInner.setSysFlag(msgExt.getSysFlag());
         msgInner.setBornTimestamp(msgExt.getBornTimestamp());
         msgInner.setBornHost(msgExt.getBornHost());
-        msgInner.setStoreHost(this.getStoreHost());
+        msgInner.setStoreHost(msgExt.getStoreHost());
         msgInner.setReconsumeTimes(msgExt.getReconsumeTimes() + 1);
 
         String originMsgId = MessageAccessor.getOriginMessageId(msgExt);
         MessageAccessor.setOriginMessageId(msgInner, UtilAll.isBlank(originMsgId) ? msgExt.getMsgId() : originMsgId);
+        CompletableFuture<PutMessageResult> putMessageResult = this.brokerController.getMessageStore().asyncPutMessage(msgInner);
+        return putMessageResult.thenApply((r) -> {
 
 Review comment:
   I think this anonymous variable `r` should be changed to `response` for readability

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services