You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2020/03/24 08:34:35 UTC

[GitHub] [royale-asjs] cristallium opened a new issue #783: j:Group itemsHorizontalAlign property issue. SDK#0.9.7 #1086

cristallium opened a new issue #783: j:Group itemsHorizontalAlign property issue. SDK#0.9.7 #1086
URL: https://github.com/apache/royale-asjs/issues/783
 
 
   Hi Carlos,
   I'm not sure if `itemsHorizontalAlign `property must exist or not for` j:Group`.
   For now, you can use it, the compiler don't complain. 
   But if you use it there is an error on runtime :
   
   ![image](https://user-images.githubusercontent.com/6851433/77404478-17418e80-6db2-11ea-9746-b13505bc3a08.png)
   
   
   Here is test case:
   
   ```
   <j:Application xmlns:fx="http://ns.adobe.com/mxml/2009" 
   	xmlns:j="library://ns.apache.org/royale/jewel" 
   	xmlns:js="library://ns.apache.org/royale/basic" 
   	xmlns:local="*" >
   
   
   	<j:valuesImpl>
   		<js:SimpleCSSValuesImpl />
   	</j:valuesImpl>
   
   	<j:initialView>
   		<j:View width="100%" height="100%">
   
   			<j:Group  width="100%" height="100%" itemsHorizontalAlign="itemsCenter">
   					<j:Card width="80%" height="10"/>
   					<j:Label text="HELLO"/>
   			</j:Group>
   
   		</j:View>
   	</j:initialView>
   
   </j:Application>
   ```
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [royale-asjs] carlosrovira commented on issue #783: j:Group itemsHorizontalAlign property issue. SDK#0.9.7 #1086

Posted by GitBox <gi...@apache.org>.
carlosrovira commented on issue #783: j:Group itemsHorizontalAlign property issue. SDK#0.9.7 #1086
URL: https://github.com/apache/royale-asjs/issues/783#issuecomment-604527103
 
 
   Hi Fred,
   
   just do the refactor to remove APIs from the Group and Container level in this commit: 59aa6238704586f4f40222fbec760b50318575a8

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [royale-asjs] carlosrovira commented on issue #783: j:Group itemsHorizontalAlign property issue. SDK#0.9.7 #1086

Posted by GitBox <gi...@apache.org>.
carlosrovira commented on issue #783: j:Group itemsHorizontalAlign property issue. SDK#0.9.7 #1086
URL: https://github.com/apache/royale-asjs/issues/783#issuecomment-604004925
 
 
   Hi Fred,
   
   this methods are to use with the subclasses VGroup and HGroup and not for Group. It's clear that does not have sense to have in the Group class, so maybe the solution is replicate in subclasses. Will see what to do in that case. Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [royale-asjs] carlosrovira closed issue #783: j:Group itemsHorizontalAlign property issue. SDK#0.9.7 #1086

Posted by GitBox <gi...@apache.org>.
carlosrovira closed issue #783: j:Group itemsHorizontalAlign property issue. SDK#0.9.7 #1086
URL: https://github.com/apache/royale-asjs/issues/783
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [royale-asjs] cristallium commented on issue #783: j:Group itemsHorizontalAlign property issue. SDK#0.9.7 #1086

Posted by GitBox <gi...@apache.org>.
cristallium commented on issue #783: j:Group itemsHorizontalAlign property issue. SDK#0.9.7 #1086
URL: https://github.com/apache/royale-asjs/issues/783#issuecomment-603102261
 
 
   same issue for itemsVerticalAlign

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [royale-asjs] cristallium commented on issue #783: j:Group itemsHorizontalAlign property issue. SDK#0.9.7 #1086

Posted by GitBox <gi...@apache.org>.
cristallium commented on issue #783: j:Group itemsHorizontalAlign property issue. SDK#0.9.7 #1086
URL: https://github.com/apache/royale-asjs/issues/783#issuecomment-604370263
 
 
   Hi Carlos,
   
   Thanks for you message.
   
   I use a lot of  code completion in VSC (visual studio code) to know what are usable property . (I was doubting myself that `itemsHorizontalAlign ` what not for `Group` )
   
   I'm afraid that a new dev guy makes like me (auto completion code),  using `itemsHorizontalAlign   ` in `Group ` and think SDK is buggy.
   
   Other than that it's not really annoying
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services