You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by "nanonyme (via GitHub)" <gi...@apache.org> on 2023/01/31 20:45:11 UTC

[GitHub] [buildstream-plugins] nanonyme commented on a diff in pull request #49: Fix using Docker plugin with multi-arch manifests

nanonyme commented on code in PR #49:
URL: https://github.com/apache/buildstream-plugins/pull/49#discussion_r1092462571


##########
src/buildstream_plugins/sources/docker.py:
##########
@@ -329,6 +328,10 @@ class DockerSource(Source):
 
     BST_MIN_VERSION = "2.0"
 
+    # url is deprecated, but accept it as a valid key so that we can raise
+    # a nicer warning.
+    CONFIG_KEYS = ["architecture", "registry-url", "image", "os", "ref", "track", "url"] + Source.COMMON_CONFIG_KEYS

Review Comment:
   It's actually *old* parameter. This plugin has been incorrectly not allowing it to be used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org