You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Michael Becke (JIRA)" <ji...@apache.org> on 2006/08/10 05:01:13 UTC
[jira] Created: (HTTPCLIENT-597) MultithreadedConnectionManager and
IdleConnectionTimeoutThread improvements
MultithreadedConnectionManager and IdleConnectionTimeoutThread improvements
---------------------------------------------------------------------------
Key: HTTPCLIENT-597
URL: http://issues.apache.org/jira/browse/HTTPCLIENT-597
Project: HttpComponents HttpClient
Issue Type: Improvement
Components: HttpClient
Affects Versions: 3.1 Beta 1
Reporter: Michael Becke
Priority: Minor
Attachments: patch.txt
Changes to MultithreadedConnectionManager and IdleConnectionTimeoutThread following the suggestions of Balazs SZÜCS.
-------- Forwarded Message --------
From: SZÜCS Balazs <Ba...@wave-solutions.com>
Reply-To: HttpClient User Discussion
<ht...@jakarta.apache.org>
To: 'HttpClient User Discussion' <ht...@jakarta.apache.org>
Subject: RE: MultithreadedConnectionManager pooling strategy
Date: Mon, 15 May 2006 15:26:08 +0200
Hello,
I made two changes to the HttpClient code:
1) in the class ConnectionPool in the method getFreeConnection( ... ) I
changed freeConnections.removeFirst() to freeConnections.removeLast(). Now
the container for free connections behaves as a stack rather than a queue.
2) additionally I changed the IdleConnectionTimeoutThread, in the run()
method I added connectionManager.deleteClosedConnections() so that the pool
size is maintained correctly.
What do you think?
Balazs
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
[jira] Closed: (HTTPCLIENT-597) MultithreadedConnectionManager and
IdleConnectionTimeoutThread improvements
Posted by "Michael Becke (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HTTPCLIENT-597?page=all ]
Michael Becke closed HTTPCLIENT-597.
------------------------------------
> MultithreadedConnectionManager and IdleConnectionTimeoutThread improvements
> ---------------------------------------------------------------------------
>
> Key: HTTPCLIENT-597
> URL: http://issues.apache.org/jira/browse/HTTPCLIENT-597
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 3.1 Alpha 1
> Reporter: Michael Becke
> Assigned To: Michael Becke
> Priority: Minor
> Fix For: 3.1 Beta 1
>
> Attachments: patch.txt
>
>
> Changes to MultithreadedConnectionManager and IdleConnectionTimeoutThread following the suggestions of Balazs SZÜCS.
> -------- Forwarded Message --------
> From: SZÜCS Balazs <Ba...@wave-solutions.com>
> Reply-To: HttpClient User Discussion
> <ht...@jakarta.apache.org>
> To: 'HttpClient User Discussion' <ht...@jakarta.apache.org>
> Subject: RE: MultithreadedConnectionManager pooling strategy
> Date: Mon, 15 May 2006 15:26:08 +0200
> Hello,
> I made two changes to the HttpClient code:
> 1) in the class ConnectionPool in the method getFreeConnection( ... ) I
> changed freeConnections.removeFirst() to freeConnections.removeLast(). Now
> the container for free connections behaves as a stack rather than a queue.
> 2) additionally I changed the IdleConnectionTimeoutThread, in the run()
> method I added connectionManager.deleteClosedConnections() so that the pool
> size is maintained correctly.
> What do you think?
> Balazs
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCLIENT-597) MultithreadedConnectionManager
and IdleConnectionTimeoutThread improvements
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HTTPCLIENT-597?page=comments#action_12427228 ]
Oleg Kalnichevski commented on HTTPCLIENT-597:
----------------------------------------------
Mike,
Could we also call #deleteClosedConnections() in the #closeIdleConnections() method of the MTHCP?
http://jakarta.apache.org/commons/httpclient/xref/org/apache/commons/httpclient/MultiThreadedHttpConnectionManager.html#596
Otherwise looks good
Oleg
> MultithreadedConnectionManager and IdleConnectionTimeoutThread improvements
> ---------------------------------------------------------------------------
>
> Key: HTTPCLIENT-597
> URL: http://issues.apache.org/jira/browse/HTTPCLIENT-597
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 3.1 Beta 1
> Reporter: Michael Becke
> Priority: Minor
> Attachments: patch.txt
>
>
> Changes to MultithreadedConnectionManager and IdleConnectionTimeoutThread following the suggestions of Balazs SZÜCS.
> -------- Forwarded Message --------
> From: SZÜCS Balazs <Ba...@wave-solutions.com>
> Reply-To: HttpClient User Discussion
> <ht...@jakarta.apache.org>
> To: 'HttpClient User Discussion' <ht...@jakarta.apache.org>
> Subject: RE: MultithreadedConnectionManager pooling strategy
> Date: Mon, 15 May 2006 15:26:08 +0200
> Hello,
> I made two changes to the HttpClient code:
> 1) in the class ConnectionPool in the method getFreeConnection( ... ) I
> changed freeConnections.removeFirst() to freeConnections.removeLast(). Now
> the container for free connections behaves as a stack rather than a queue.
> 2) additionally I changed the IdleConnectionTimeoutThread, in the run()
> method I added connectionManager.deleteClosedConnections() so that the pool
> size is maintained correctly.
> What do you think?
> Balazs
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
[jira] Resolved: (HTTPCLIENT-597) MultithreadedConnectionManager
and IdleConnectionTimeoutThread improvements
Posted by "Michael Becke (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HTTPCLIENT-597?page=all ]
Michael Becke resolved HTTPCLIENT-597.
--------------------------------------
Resolution: Fixed
Assignee: Michael Becke
Patch applied.
> MultithreadedConnectionManager and IdleConnectionTimeoutThread improvements
> ---------------------------------------------------------------------------
>
> Key: HTTPCLIENT-597
> URL: http://issues.apache.org/jira/browse/HTTPCLIENT-597
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 3.1 Alpha 1
> Reporter: Michael Becke
> Assigned To: Michael Becke
> Priority: Minor
> Fix For: 3.1 Beta 1
>
> Attachments: patch.txt
>
>
> Changes to MultithreadedConnectionManager and IdleConnectionTimeoutThread following the suggestions of Balazs SZÜCS.
> -------- Forwarded Message --------
> From: SZÜCS Balazs <Ba...@wave-solutions.com>
> Reply-To: HttpClient User Discussion
> <ht...@jakarta.apache.org>
> To: 'HttpClient User Discussion' <ht...@jakarta.apache.org>
> Subject: RE: MultithreadedConnectionManager pooling strategy
> Date: Mon, 15 May 2006 15:26:08 +0200
> Hello,
> I made two changes to the HttpClient code:
> 1) in the class ConnectionPool in the method getFreeConnection( ... ) I
> changed freeConnections.removeFirst() to freeConnections.removeLast(). Now
> the container for free connections behaves as a stack rather than a queue.
> 2) additionally I changed the IdleConnectionTimeoutThread, in the run()
> method I added connectionManager.deleteClosedConnections() so that the pool
> size is maintained correctly.
> What do you think?
> Balazs
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
[jira] Updated: (HTTPCLIENT-597) MultithreadedConnectionManager and
IdleConnectionTimeoutThread improvements
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HTTPCLIENT-597?page=all ]
Oleg Kalnichevski updated HTTPCLIENT-597:
-----------------------------------------
Fix Version/s: 3.1 Beta 1
Affects Version/s: 3.1 Alpha 1
(was: 3.1 Beta 1)
> MultithreadedConnectionManager and IdleConnectionTimeoutThread improvements
> ---------------------------------------------------------------------------
>
> Key: HTTPCLIENT-597
> URL: http://issues.apache.org/jira/browse/HTTPCLIENT-597
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 3.1 Alpha 1
> Reporter: Michael Becke
> Priority: Minor
> Fix For: 3.1 Beta 1
>
> Attachments: patch.txt
>
>
> Changes to MultithreadedConnectionManager and IdleConnectionTimeoutThread following the suggestions of Balazs SZÜCS.
> -------- Forwarded Message --------
> From: SZÜCS Balazs <Ba...@wave-solutions.com>
> Reply-To: HttpClient User Discussion
> <ht...@jakarta.apache.org>
> To: 'HttpClient User Discussion' <ht...@jakarta.apache.org>
> Subject: RE: MultithreadedConnectionManager pooling strategy
> Date: Mon, 15 May 2006 15:26:08 +0200
> Hello,
> I made two changes to the HttpClient code:
> 1) in the class ConnectionPool in the method getFreeConnection( ... ) I
> changed freeConnections.removeFirst() to freeConnections.removeLast(). Now
> the container for free connections behaves as a stack rather than a queue.
> 2) additionally I changed the IdleConnectionTimeoutThread, in the run()
> method I added connectionManager.deleteClosedConnections() so that the pool
> size is maintained correctly.
> What do you think?
> Balazs
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org