You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2014/06/15 07:41:55 UTC

[Bug 7052] New: Net-DNS-Nameserver Dependency clarification

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7052

            Bug ID: 7052
           Summary: Net-DNS-Nameserver Dependency clarification
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Hardware: PC
                OS: Windows 7
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Regression Tests
          Assignee: dev@spamassassin.apache.org
          Reporter: kmcgrail@pccc.com

With RHEL/CentOS, Net-DNS is split into Net-DNS and Net-DNS-Nameserver.

This causes issues such as:

t/dnsbl_subtests.t ................ Can't locate Net/DNS/Nameserver.pm in @INC
(@INC contains: t . /tmp/spamassassin-trunk/blib/lib
/tmp/spamassassin-trunk/blib/arch /usr/local/lib64/perl5 /usr/local/share/perl5
/usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5
/usr/share/perl5) at t/dnsbl_subtests.t line 29.
BEGIN failed--compilation aborted at t/dnsbl_subtests.t line 29.
t/dnsbl_subtests.t ................ Dubious, test returned 2 (wstat 512, 0x200)
Failed 46/46 subtests


The solution on RHEL/CentOS systems is to install perl-Net-DNS-Nameserver using
yum, for example.

However, since perl-Net-DNS-Nameserver is required and RHEL/CentOS separately
installs it, add it as a requirement to the Makefile.PL with a note about
Centos splitting http://search.cpan.org/~nlnetlabs/Net-DNS-0.77/

Found this while working on rule updates on the new spamassassin-vm box.  Patch
is finished pending test and commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7052] Net-DNS-Nameserver Dependency clarification

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7052

--- Comment #5 from AXB <ax...@gmail.com> ---
Centos provides Net::DNS::Nameserver

yum install perl-Net-DNS-Nameserver.x86_64

as it seems ONLY "make test" requires Net::DNS::Nameserver
Is that dependency is really required or just a legacy one?

For regular SA operation is should NOT be required.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7052] Net-DNS-Nameserver Dependency clarification

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7052

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Kevin A. McGrail <km...@pccc.com> ---
(In reply to AXB from comment #7)
> to avoid possibly instantly breaking ppl's deploy scripts, could you please 
> make it "optional"

As I'm the only one who reported the issue, I'll agree barring others weighing
in.

svn commit -m 'Moved Net::DNS::Nameserver to optional since it is just use in
make test - Bug 7052'

Sending        Makefile.PL
Sending        lib/Mail/SpamAssassin/Util/DependencyInfo.pm
Transmitting file data ..
Committed revision 1603304.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7052] Net-DNS-Nameserver Dependency clarification

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7052

--- Comment #6 from Kevin A. McGrail <km...@pccc.com> ---
It's needed to pass make test and I need that to get the rule gen working so
for me, this is really minor nit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7052] Net-DNS-Nameserver Dependency clarification

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7052

--- Comment #7 from AXB <ax...@gmail.com> ---
(In reply to Kevin A. McGrail from comment #6)
> It's needed to pass make test and I need that to get the rule gen working so
> for me, this is really minor nit.

to avoid possibly instantly breaking ppl's deploy scripts, could you please 
make it "optional"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7052] Net-DNS-Nameserver Dependency clarification

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7052

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |kmcgrail@pccc.com
         Resolution|---                         |FIXED

--- Comment #1 from Kevin A. McGrail <km...@pccc.com> ---
svn commit -m 'Fix for Net::DNS::Nameserver dependency on CentOS systems - bug
7052'
Sending        Makefile.PL
Sending        lib/Mail/SpamAssassin/Util/DependencyInfo.pm
Transmitting file data ..
Committed revision 1602660.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7052] Net-DNS-Nameserver Dependency clarification

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7052

--- Comment #2 from AXB <ax...@gmail.com> ---
A regular SA setup on Centos 6.x does NOT require perl-Net-DNS-Nameserver
There  must be something else that required you to install this on that box

Please review this as it seems like an unnecessary dependency

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7052] Net-DNS-Nameserver Dependency clarification

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7052

--- Comment #4 from Kevin A. McGrail <km...@pccc.com> ---
(In reply to AXB from comment #2)
> A regular SA setup on Centos 6.x does NOT require perl-Net-DNS-Nameserver
> There  must be something else that required you to install this on that box
> 
> Please review this as it seems like an unnecessary dependency

A make test fails on t/dnsbl_subtests.t as noted if you install perl-Net-DNS
but not perl-Net-DNS-Namserver on CentOS 6.5.

the t file includes: use Net::DNS::Nameserver;

As noted, if you have Net::DNS installed from source, you get
Net::DNS::Nameserver by default.  RHEL/CentOS split the module.  Not sure why.

> please do no recommend using CPAN modules on RH flavours as they _can_ 
> cause all kinds of dependency issues with core modules.

I didn't.  I recommended installing the stock RPMs for perl-Net-DNS and
perl-Net-DNS-Nameserver.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7052] Net-DNS-Nameserver Dependency clarification

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7052

AXB <ax...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #3 from AXB <ax...@gmail.com> ---
please do no recommend using CPAN modules on RH flavours as they _can_ cause
all kinds of dependency issues with core modules.
If anything point to a 3rd party rpm reposity and use yum with, EPEL,
Repoforge, etc.

yum install
http://pkgs.repoforge.org/perl-Net-DNS/perl-Net-DNS-0.71-1.el6.rfx.x86_64.rpm

-- 
You are receiving this mail because:
You are the assignee for the bug.