You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2014/12/03 17:35:37 UTC
Re: svn commit: r1637832 - /commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java
On 10 November 2014 at 12:54, <gg...@apache.org> wrote:
> Author: ggregory
> Date: Mon Nov 10 12:54:57 2014
> New Revision: 1637832
>
> URL: http://svn.apache.org/r1637832
> Log:
> Move static var decl.
Why?
Most components I have worked on have the constants at the start.
> Modified:
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java
>
> Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java
> URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java?rev=1637832&r1=1637831&r2=1637832&view=diff
> ==============================================================================
> --- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java (original)
> +++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java Mon Nov 10 12:54:57 2014
> @@ -33,8 +33,6 @@ import org.apache.commons.codec.binary.S
> */
> public class DigestUtils {
>
> - private static final int STREAM_BUFFER_LENGTH = 1024;
> -
> /**
> * Read through an InputStream and returns the digest for the data
> *
> @@ -816,4 +814,6 @@ public class DigestUtils {
> messageDigest.update(StringUtils.getBytesUtf8(valueToDigest));
> return messageDigest;
> }
> +
> + private static final int STREAM_BUFFER_LENGTH = 1024;
> }
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1637832 - /commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java
Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Dec 3, 2014 at 11:35 AM, sebb <se...@gmail.com> wrote:
> On 10 November 2014 at 12:54, <gg...@apache.org> wrote:
> > Author: ggregory
> > Date: Mon Nov 10 12:54:57 2014
> > New Revision: 1637832
> >
> > URL: http://svn.apache.org/r1637832
> > Log:
> > Move static var decl.
>
> Why?
>
> Most components I have worked on have the constants at the start.
>
The current code has the decl at the start. I can't quite recall what
happened with this commit three weeks ago though, odd.
Gary
> > Modified:
> >
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java
> >
> > Modified:
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java?rev=1637832&r1=1637831&r2=1637832&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java
> (original)
> > +++
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java
> Mon Nov 10 12:54:57 2014
> > @@ -33,8 +33,6 @@ import org.apache.commons.codec.binary.S
> > */
> > public class DigestUtils {
> >
> > - private static final int STREAM_BUFFER_LENGTH = 1024;
> > -
> > /**
> > * Read through an InputStream and returns the digest for the data
> > *
> > @@ -816,4 +814,6 @@ public class DigestUtils {
> > messageDigest.update(StringUtils.getBytesUtf8(valueToDigest));
> > return messageDigest;
> > }
> > +
> > + private static final int STREAM_BUFFER_LENGTH = 1024;
> > }
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory