[GitHub] [ant] jaikiran commented on a diff in pull request #199: Use verbose log level for loading stylesheets

["jaikiran (via GitHub)" <gi...@apache.org>]

jaikiran commented on code in PR #199:
URL: https://github.com/apache/ant/pull/199#discussion_r1118656632


##########
src/main/org/apache/tools/ant/taskdefs/XSLTProcess.java:
##########
@@ -1258,7 +1258,7 @@ protected void configureLiaison(final Resource stylesheet) throws BuildException
         stylesheetLoaded = true;
 
         try {
-            log("Loading stylesheet " + stylesheet, Project.MSG_INFO);
+            log("Loading stylesheet " + stylesheet, Project.MSG_VERBOSE);

Review Comment:
   Thank you Christoph for this change. I'm surprised it was logging the contents of the file. I think what we should probably do here is keep it at `INFO` level but change the log message to just print the name of the resource :
   ```
   log("Loading stylesheet " + stylesheet.getName(), Project.MSG_INFO);
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org