You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2020/03/15 00:04:06 UTC
Review Request 72236: ATLAS-3666: updated file-based authentication
to use BCrypt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72236/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Mehul Parikh, Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth Mishra.
Bugs: ATLAS-3666
https://issues.apache.org/jira/browse/ATLAS-3666
Repository: atlas
Description
-------
- updated file-based authentication to use bcrypt encryption
Diffs
-----
webapp/src/main/java/org/apache/atlas/util/CredentialProviderUtility.java 5005f79d9
webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java 7fdce3a1f
webapp/src/main/java/org/apache/atlas/web/security/AtlasFileAuthenticationProvider.java 7269d4c21
Diff: https://reviews.apache.org/r/72236/diff/1/
Testing
-------
- manually verified that file-based authentication validates bcrypt encrypted passwords correctly
- pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1737/
Thanks,
Madhan Neethiraj
Re: Review Request 72236: ATLAS-3666: updated file-based
authentication to use BCrypt
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72236/#review219942
-----------------------------------------------------------
Ship it!
Found this UT's failing. this UT's needs to be updated.
FileAuthenticationTest.testUserRoleMapping:198 » BadCredentials Wrong password
FileAuthenticationTest.testValidUserLogin:120 » BadCredentials Wrong password
FileAuthenticationTest.testValidUserLoginWithV1password:132 » BadCredentials W...
- Nixon Rodrigues
On March 15, 2020, 12:04 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72236/
> -----------------------------------------------------------
>
> (Updated March 15, 2020, 12:04 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Mehul Parikh, Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth Mishra.
>
>
> Bugs: ATLAS-3666
> https://issues.apache.org/jira/browse/ATLAS-3666
>
>
> Repository: atlas
>
>
> Description
> -------
>
> - updated file-based authentication to use bcrypt encryption
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/util/CredentialProviderUtility.java 5005f79d9
> webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java 7fdce3a1f
> webapp/src/main/java/org/apache/atlas/web/security/AtlasFileAuthenticationProvider.java 7269d4c21
>
>
> Diff: https://reviews.apache.org/r/72236/diff/1/
>
>
> Testing
> -------
>
> - manually verified that file-based authentication validates bcrypt encrypted passwords correctly
> - pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1737/
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 72236: ATLAS-3666: updated file-based
authentication to use BCrypt
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72236/
-----------------------------------------------------------
(Updated March 15, 2020, 8:31 p.m.)
Review request for atlas, Ashutosh Mestry, Mehul Parikh, Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth Mishra.
Changes
-------
- added and updated unit tests
Bugs: ATLAS-3666
https://issues.apache.org/jira/browse/ATLAS-3666
Repository: atlas
Description
-------
- updated file-based authentication to use bcrypt encryption
Diffs (updated)
-----
webapp/src/main/java/org/apache/atlas/util/CredentialProviderUtility.java 5005f79d9
webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java 7fdce3a1f
webapp/src/main/java/org/apache/atlas/web/security/AtlasFileAuthenticationProvider.java 7269d4c21
webapp/src/test/java/org/apache/atlas/web/security/FileAuthenticationTest.java 6cd50173e
Diff: https://reviews.apache.org/r/72236/diff/2/
Changes: https://reviews.apache.org/r/72236/diff/1-2/
Testing (updated)
-------
- manually verified that file-based authentication validates bcrypt encrypted passwords correctly
- pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1739/
Thanks,
Madhan Neethiraj
Re: Review Request 72236: ATLAS-3666: updated file-based
authentication to use BCrypt
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72236/#review219941
-----------------------------------------------------------
Ship it!
Ship It!
- Nixon Rodrigues
On March 15, 2020, 12:04 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72236/
> -----------------------------------------------------------
>
> (Updated March 15, 2020, 12:04 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Mehul Parikh, Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth Mishra.
>
>
> Bugs: ATLAS-3666
> https://issues.apache.org/jira/browse/ATLAS-3666
>
>
> Repository: atlas
>
>
> Description
> -------
>
> - updated file-based authentication to use bcrypt encryption
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/util/CredentialProviderUtility.java 5005f79d9
> webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java 7fdce3a1f
> webapp/src/main/java/org/apache/atlas/web/security/AtlasFileAuthenticationProvider.java 7269d4c21
>
>
> Diff: https://reviews.apache.org/r/72236/diff/1/
>
>
> Testing
> -------
>
> - manually verified that file-based authentication validates bcrypt encrypted passwords correctly
> - pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1737/
>
>
> Thanks,
>
> Madhan Neethiraj
>
>