You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Anthony Molinaro (JIRA)" <ji...@apache.org> on 2009/12/12 01:44:18 UTC
[jira] Created: (THRIFT-647) PHP library is missing install target
PHP library is missing install target
-------------------------------------
Key: THRIFT-647
URL: https://issues.apache.org/jira/browse/THRIFT-647
Project: Thrift
Issue Type: Bug
Components: Library (PHP)
Affects Versions: 0.2
Reporter: Anthony Molinaro
Attachments: Makefile.am, php.patch
It would be useful when php is detected to install the php library on the system the same way other libraries are installed.
To do this I added the attached Makefile.am into the lib/php directory and modifed configure.ac and lib/Makefile.am to cause automake to recognize it when PHP is installed. It defaults to installing in /usr/lib/php but can be overridden using the PHP_PREFIX environment variable, similar to python and java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-647) PHP library is missing install target
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-647:
-------------------------------
Attachment: v1-0001-THRIFT-647.-php-Add-license-header-and-fix-style-in-.patch
> PHP library is missing install target
> -------------------------------------
>
> Key: THRIFT-647
> URL: https://issues.apache.org/jira/browse/THRIFT-647
> Project: Thrift
> Issue Type: Bug
> Components: Library (PHP)
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: Anthony Molinaro
> Fix For: 0.4
>
> Attachments: Makefile.am, php.patch, v1-0001-THRIFT-647.-php-Add-license-header-and-fix-style-in-.patch
>
>
> It would be useful when php is detected to install the php library on the system the same way other libraries are installed.
> To do this I added the attached Makefile.am into the lib/php directory and modifed configure.ac and lib/Makefile.am to cause automake to recognize it when PHP is installed. It defaults to installing in /usr/lib/php but can be overridden using the PHP_PREFIX environment variable, similar to python and java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-647) PHP library is missing install
target
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863817#action_12863817 ]
Bryan Duxbury commented on THRIFT-647:
--------------------------------------
David - are you planning to apply that extra "style" patch you attached? I have no problem with you just committing it.
> PHP library is missing install target
> -------------------------------------
>
> Key: THRIFT-647
> URL: https://issues.apache.org/jira/browse/THRIFT-647
> Project: Thrift
> Issue Type: Bug
> Components: Library (PHP)
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: Anthony Molinaro
> Fix For: 0.4
>
> Attachments: Makefile.am, php.patch, v1-0001-THRIFT-647.-php-Add-license-header-and-fix-style-in-.patch
>
>
> It would be useful when php is detected to install the php library on the system the same way other libraries are installed.
> To do this I added the attached Makefile.am into the lib/php directory and modifed configure.ac and lib/Makefile.am to cause automake to recognize it when PHP is installed. It defaults to installing in /usr/lib/php but can be overridden using the PHP_PREFIX environment variable, similar to python and java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-647) PHP library is missing install
target
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863816#action_12863816 ]
Bryan Duxbury commented on THRIFT-647:
--------------------------------------
(reverted the changes to the java lib)
> PHP library is missing install target
> -------------------------------------
>
> Key: THRIFT-647
> URL: https://issues.apache.org/jira/browse/THRIFT-647
> Project: Thrift
> Issue Type: Bug
> Components: Library (PHP)
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: Anthony Molinaro
> Fix For: 0.4
>
> Attachments: Makefile.am, php.patch, v1-0001-THRIFT-647.-php-Add-license-header-and-fix-style-in-.patch
>
>
> It would be useful when php is detected to install the php library on the system the same way other libraries are installed.
> To do this I added the attached Makefile.am into the lib/php directory and modifed configure.ac and lib/Makefile.am to cause automake to recognize it when PHP is installed. It defaults to installing in /usr/lib/php but can be overridden using the PHP_PREFIX environment variable, similar to python and java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-647) PHP library is missing install target
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-647.
--------------------------------
Assignee: Anthony Molinaro
Fix Version/s: 0.4
Resolution: Fixed
I just committed this.
> PHP library is missing install target
> -------------------------------------
>
> Key: THRIFT-647
> URL: https://issues.apache.org/jira/browse/THRIFT-647
> Project: Thrift
> Issue Type: Bug
> Components: Library (PHP)
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: Anthony Molinaro
> Fix For: 0.4
>
> Attachments: Makefile.am, php.patch
>
>
> It would be useful when php is detected to install the php library on the system the same way other libraries are installed.
> To do this I added the attached Makefile.am into the lib/php directory and modifed configure.ac and lib/Makefile.am to cause automake to recognize it when PHP is installed. It defaults to installing in /usr/lib/php but can be overridden using the PHP_PREFIX environment variable, similar to python and java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-647) PHP library is missing install
target
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863815#action_12863815 ]
Bryan Duxbury commented on THRIFT-647:
--------------------------------------
Ah, good catch. It looks like that was an unintentional leftover from one of my checkouts.
> PHP library is missing install target
> -------------------------------------
>
> Key: THRIFT-647
> URL: https://issues.apache.org/jira/browse/THRIFT-647
> Project: Thrift
> Issue Type: Bug
> Components: Library (PHP)
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: Anthony Molinaro
> Fix For: 0.4
>
> Attachments: Makefile.am, php.patch, v1-0001-THRIFT-647.-php-Add-license-header-and-fix-style-in-.patch
>
>
> It would be useful when php is detected to install the php library on the system the same way other libraries are installed.
> To do this I added the attached Makefile.am into the lib/php directory and modifed configure.ac and lib/Makefile.am to cause automake to recognize it when PHP is installed. It defaults to installing in /usr/lib/php but can be overridden using the PHP_PREFIX environment variable, similar to python and java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-647) PHP library is missing install
target
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863681#action_12863681 ]
David Reiss commented on THRIFT-647:
------------------------------------
Why was there a change to the Java generator in this commit?
> PHP library is missing install target
> -------------------------------------
>
> Key: THRIFT-647
> URL: https://issues.apache.org/jira/browse/THRIFT-647
> Project: Thrift
> Issue Type: Bug
> Components: Library (PHP)
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: Anthony Molinaro
> Fix For: 0.4
>
> Attachments: Makefile.am, php.patch
>
>
> It would be useful when php is detected to install the php library on the system the same way other libraries are installed.
> To do this I added the attached Makefile.am into the lib/php directory and modifed configure.ac and lib/Makefile.am to cause automake to recognize it when PHP is installed. It defaults to installing in /usr/lib/php but can be overridden using the PHP_PREFIX environment variable, similar to python and java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-647) PHP library is missing install target
Posted by "Anthony Molinaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anthony Molinaro updated THRIFT-647:
------------------------------------
Attachment: php.patch
Makefile.am
> PHP library is missing install target
> -------------------------------------
>
> Key: THRIFT-647
> URL: https://issues.apache.org/jira/browse/THRIFT-647
> Project: Thrift
> Issue Type: Bug
> Components: Library (PHP)
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Attachments: Makefile.am, php.patch
>
>
> It would be useful when php is detected to install the php library on the system the same way other libraries are installed.
> To do this I added the attached Makefile.am into the lib/php directory and modifed configure.ac and lib/Makefile.am to cause automake to recognize it when PHP is installed. It defaults to installing in /usr/lib/php but can be overridden using the PHP_PREFIX environment variable, similar to python and java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.