You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jake Farrell <jf...@apache.org> on 2014/01/17 04:52:11 UTC

Review Request 17030: AURORA-3: Update code for ASF namespace and license headers

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17030/
-----------------------------------------------------------

Review request for Aurora, Dave Lester, Kevin Sweeney, Bill Farner, and Brian Wickman.


Bugs: AURORA-3
    https://issues.apache.org/jira/browse/AURORA-3


Repository: aurora


Description
-------

AURORA-3: Update code for ASF namespace and license headers

Adds the NOTICE file and updates the LICENSE


Diffs
-----

  LICENSE 23096644c33492dea8bb9e3a9736245247a64bc5 
  NOTICE PRE-CREATION 

Diff: https://reviews.apache.org/r/17030/diff/


Testing
-------


Thanks,

Jake Farrell


Re: Review Request 17030: AURORA-3: Update code for ASF namespace and license headers

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17030/#review32166
-----------------------------------------------------------


This is now on master as e3e81a1.  Thanks!

- Bill Farner


On Jan. 17, 2014, 6:20 p.m., Jake Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17030/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 6:20 p.m.)
> 
> 
> Review request for Aurora, Dave Lester, Kevin Sweeney, Bill Farner, and Brian Wickman.
> 
> 
> Bugs: AURORA-3
>     https://issues.apache.org/jira/browse/AURORA-3
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-3: Update code for ASF namespace and license headers
> 
> Adds the NOTICE file and updates the LICENSE
> 
> 
> Diffs
> -----
> 
>   LICENSE 23096644c33492dea8bb9e3a9736245247a64bc5 
>   NOTICE PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17030/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>


Re: Review Request 17030: AURORA-3: Update code for ASF namespace and license headers

Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17030/
-----------------------------------------------------------

(Updated Jan. 17, 2014, 6:20 p.m.)


Review request for Aurora, Dave Lester, Kevin Sweeney, Bill Farner, and Brian Wickman.


Changes
-------

Removed newline


Bugs: AURORA-3
    https://issues.apache.org/jira/browse/AURORA-3


Repository: aurora


Description
-------

AURORA-3: Update code for ASF namespace and license headers

Adds the NOTICE file and updates the LICENSE


Diffs (updated)
-----

  LICENSE 23096644c33492dea8bb9e3a9736245247a64bc5 
  NOTICE PRE-CREATION 

Diff: https://reviews.apache.org/r/17030/diff/


Testing
-------


Thanks,

Jake Farrell


Re: Review Request 17030: AURORA-3: Update code for ASF namespace and license headers

Posted by Jake Farrell <jf...@apache.org>.

> On Jan. 17, 2014, 5:56 p.m., Bill Farner wrote:
> > Wow, thanks for seeding this!!

I'll add the python dependencies to this when I do the dependency reorganization for AURORA-30


- Jake


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17030/#review32153
-----------------------------------------------------------


On Jan. 17, 2014, 3:52 a.m., Jake Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17030/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 3:52 a.m.)
> 
> 
> Review request for Aurora, Dave Lester, Kevin Sweeney, Bill Farner, and Brian Wickman.
> 
> 
> Bugs: AURORA-3
>     https://issues.apache.org/jira/browse/AURORA-3
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-3: Update code for ASF namespace and license headers
> 
> Adds the NOTICE file and updates the LICENSE
> 
> 
> Diffs
> -----
> 
>   LICENSE 23096644c33492dea8bb9e3a9736245247a64bc5 
>   NOTICE PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17030/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>


Re: Review Request 17030: AURORA-3: Update code for ASF namespace and license headers

Posted by Jake Farrell <jf...@apache.org>.

> On Jan. 17, 2014, 5:56 p.m., Bill Farner wrote:
> > NOTICE, line 2
> > <https://reviews.apache.org/r/17030/diff/1/?file=425930#file425930line2>
> >
> >     2014?

the vote to add you into the incubator was in 2013, matches what is set in the LICENSE at the bottom


> On Jan. 17, 2014, 5:56 p.m., Bill Farner wrote:
> > NOTICE, line 51
> > <https://reviews.apache.org/r/17030/diff/1/?file=425930#file425930line51>
> >
> >     kill extra newlines

will remove


- Jake


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17030/#review32153
-----------------------------------------------------------


On Jan. 17, 2014, 3:52 a.m., Jake Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17030/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 3:52 a.m.)
> 
> 
> Review request for Aurora, Dave Lester, Kevin Sweeney, Bill Farner, and Brian Wickman.
> 
> 
> Bugs: AURORA-3
>     https://issues.apache.org/jira/browse/AURORA-3
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-3: Update code for ASF namespace and license headers
> 
> Adds the NOTICE file and updates the LICENSE
> 
> 
> Diffs
> -----
> 
>   LICENSE 23096644c33492dea8bb9e3a9736245247a64bc5 
>   NOTICE PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17030/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>


Re: Review Request 17030: AURORA-3: Update code for ASF namespace and license headers

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17030/#review32153
-----------------------------------------------------------

Ship it!


Wow, thanks for seeding this!!


NOTICE
<https://reviews.apache.org/r/17030/#comment60856>

    2014?



NOTICE
<https://reviews.apache.org/r/17030/#comment60857>

    kill extra newlines


- Bill Farner


On Jan. 17, 2014, 3:52 a.m., Jake Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17030/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 3:52 a.m.)
> 
> 
> Review request for Aurora, Dave Lester, Kevin Sweeney, Bill Farner, and Brian Wickman.
> 
> 
> Bugs: AURORA-3
>     https://issues.apache.org/jira/browse/AURORA-3
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-3: Update code for ASF namespace and license headers
> 
> Adds the NOTICE file and updates the LICENSE
> 
> 
> Diffs
> -----
> 
>   LICENSE 23096644c33492dea8bb9e3a9736245247a64bc5 
>   NOTICE PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17030/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>