You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/02/26 18:46:55 UTC
[GitHub] [helix] zhangmeng916 opened a new pull request #815: add listener
and config for customized view aggregation
zhangmeng916 opened a new pull request #815: add listener and config for customized view aggregation
URL: https://github.com/apache/helix/pull/815
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
(#728 )
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
Helix will introduce the concept of customized state, which allows customer to define the states they are interested. Helix will also provide customers to aggregate their customized state to customized view, similar to CURRENT_STATE to EXTERNAL_VIEW aggregation.
This PR adds necessary listeners to existing managers, and also update some config for having new customized state and view.
### Tests
- [X] The following is the result of the "mvn test" command on the appropriate module:
### Commits
- [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [X] My diff has been formatted using helix-style.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on issue #815: add listener and
config for customized view aggregation
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on issue #815: add listener and config for customized view aggregation
URL: https://github.com/apache/helix/pull/815#issuecomment-591707863
This PR is ready for merge, approved by @alirezazamani
Final commit message
"Add listeners for customized state and customized state aggregation config in Helix managers"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani commented on a change in pull request #815:
add listener and config for customized view aggregation
Posted by GitBox <gi...@apache.org>.
alirezazamani commented on a change in pull request #815: add listener and config for customized view aggregation
URL: https://github.com/apache/helix/pull/815#discussion_r384785913
##########
File path: helix-core/src/main/java/org/apache/helix/PropertyType.java
##########
@@ -43,12 +43,12 @@
INSTANCES(Type.CLUSTER, true, false),
IDEALSTATES(Type.CLUSTER, true, false, false, false, true),
EXTERNALVIEW(Type.CLUSTER, true, false),
+ CUSTOMIZEDVIEW(Type.CLUSTER, true, false),
TARGETEXTERNALVIEW(Type.CLUSTER, true, false),
STATEMODELDEFS(Type.CLUSTER, true, false, false, false, true),
CONTROLLER(Type.CLUSTER, true, false),
PROPERTYSTORE(Type.CLUSTER, true, false),
- // INSTANCE PROPERTIES
Review comment:
can you add back this comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang merged pull request #815: add listener and
config for customized view aggregation
Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #815: add listener and config for customized view aggregation
URL: https://github.com/apache/helix/pull/815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org