You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/10/17 12:59:58 UTC
[GitHub] [incubator-dolphinscheduler-website] Segun-Ogundipe opened a new pull request #196: [Feature][Dev] Translate Microbench To English
Segun-Ogundipe opened a new pull request #196:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/196
# What is the purpose of the pull request
This PR adds the English translation of microbench Chinese documentation to the website.
# Change Log
- Add "docs/en-us/development/microbench.md"
- Modified "site_config/development.js"
# How to verify this PR
- Clone the branch
- npm i
- docsite start
- Go to "http://localhost:8080/en-us/docs/development/microbench.html"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] Segun-Ogundipe commented on a change in pull request #196: [Feature][Dev] Translate Microbench To English
Posted by GitBox <gi...@apache.org>.
Segun-Ogundipe commented on a change in pull request #196:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/196#discussion_r506968395
##########
File path: site_config/development.js
##########
@@ -1,163 +1,167 @@
export default {
- 'en-us': {
- sidemenu: [
- {
- title: 'Contribution Guide',
- children: [
- {
- title: 'how to become a committer',
- link: '/en-us/docs/development/become a committer.html',
- },
Review comment:
I only added a new entry for microbench link as was documented in the README.md file. My linter formatted the file and that's why the whole file shows to be edited.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] CalvinKirs merged pull request #196: [Feature][Dev] Translate Microbench To English
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #196:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/196
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] CalvinKirs commented on pull request #196: [Feature][Dev] Translate Microbench To English
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #196:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/196#issuecomment-712562705
Hi, please resolve the conflict..thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] CalvinKirs commented on a change in pull request #196: [Feature][Dev] Translate Microbench To English
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #196:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/196#discussion_r506965501
##########
File path: site_config/development.js
##########
@@ -1,163 +1,167 @@
export default {
- 'en-us': {
- sidemenu: [
- {
- title: 'Contribution Guide',
- children: [
- {
- title: 'how to become a committer',
- link: '/en-us/docs/development/become a committer.html',
- },
Review comment:
It is recommended not to change these, especially in terms of code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] Segun-Ogundipe commented on pull request #196: [Feature][Dev] Translate Microbench To English
Posted by GitBox <gi...@apache.org>.
Segun-Ogundipe commented on pull request #196:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/196#issuecomment-712742818
> Hi, please resolve the conflict..thx
Done @CalvinKirs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] CalvinKirs commented on pull request #196: [Feature][Dev] Translate Microbench To English
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #196:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/196#issuecomment-711119058
@Tianqi-Dotes PTAL?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org