You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/26 20:38:46 UTC

[GitHub] [spark] mgaido91 commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result

mgaido91 commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result
URL: https://github.com/apache/spark/pull/21599#issuecomment-515592086
 
 
   thanks for your comment @cloud-fan. I am working in order to address your comments.
   
   Regarding to 2, in Postgres, any operation involving an infinite returns infinite, while +infinite - infinite returns NaN. I am not sure why you have concerns using signum for detecting overflow. May you elaborate it? That's basically the definition of an overflow...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org