You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "xiazcy (via GitHub)" <gi...@apache.org> on 2025/10/29 21:44:09 UTC

[PR] Backport proper `statics.BigDecimal` implementation for `gremlin-python` from 4.0.0 [tinkerpop]

xiazcy opened a new pull request, #3256:
URL: https://github.com/apache/tinkerpop/pull/3256

   Backported `statics.BigDecimal` implementation from 4.0.0 for `gremlin-python`, with slight updates and fixed related bugs in testing. It now properly calculated the `scale` and unscaled_value` as represented in the Gremlin BigDecimal (JVM-based) for serialization purposes. Added a method to construct it from string or numbers, as well as the `statics.BigDecimal.value` attribute to get a python `decimal.Decimal` representation. 
   
   Also made both `GraphBinary` and `GraphSON `consistent in deserializing into the new `statics.BigDecimal` class, which could be considered breaking for `GraphSON` users that used to rely on it returning python's `decimal.Decimal` in previous versions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Backport proper `statics.BigDecimal` implementation for `gremlin-python` from 4.0.0 [tinkerpop]

Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #3256:
URL: https://github.com/apache/tinkerpop/pull/3256#issuecomment-3470301924

   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Backport proper `statics.BigDecimal` implementation for `gremlin-python` from 4.0.0 [tinkerpop]

Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #3256:
URL: https://github.com/apache/tinkerpop/pull/3256#issuecomment-3470465403

   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Backport proper `statics.BigDecimal` implementation for `gremlin-python` from 4.0.0 [tinkerpop]

Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy merged PR #3256:
URL: https://github.com/apache/tinkerpop/pull/3256


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org