You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by vitalpoltava <gi...@git.apache.org> on 2014/08/11 22:53:15 UTC
[GitHub] thrift pull request: Seems the wrong prop name (should be recv_buf...
GitHub user vitalpoltava opened a pull request:
https://github.com/apache/thrift/pull/185
Seems the wrong prop name (should be recv_buf)
Seems the name of the property is not correct -- it is read_buf, yet it should be recv_buf.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vitalpoltava/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #185
----
commit 2392bfe20bd818154629d3662b572d912bf404ea
Author: Vitaliy Omelkin <om...@gmail.com>
Date: 2014-08-11T20:47:11Z
Seems the wrong prop name (should be recv_buf)
Seems the name of the property is not correct -- it is read_buf, yet it should be recv_buf.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Seems the wrong prop name (should be recv_buf...
Posted by hcorg <gi...@git.apache.org>.
Github user hcorg commented on the pull request:
https://github.com/apache/thrift/pull/185#issuecomment-57616576
Please create Jira issue and paste link to it into comment here
http://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Seems the wrong prop name (should be recv_buf...
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/185
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Seems the wrong prop name (should be recv_buf...
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/185#issuecomment-93616831
Thanks for your patch @vitalpoltava, in order for us to accept a pull request we need to have a jira ticket associated with it. Please see our contributing guide at http://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---