[GitHub] [doris] morrySnow commented on a diff in pull request #20485: [fix](nereids) Fix status update

["morrySnow (via GitHub)" <gi...@apache.org>]

morrySnow commented on code in PR #20485:
URL: https://github.com/apache/doris/pull/20485#discussion_r1220718843


##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -2423,8 +2423,7 @@ public List<ResultRow> executeInternalQuery() {
                     analyze(context.getSessionVariable().toThrift());
                 }
             } catch (Exception e) {
-                LOG.warn("Internal SQL execution failed, SQL: {}", originStmt, e);
-                return resultRows;
+                throw new RuntimeException("Failed to execute internal SQL", e);

Review Comment:
   do we need to add origin sql into exception msg?



##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -2423,8 +2423,7 @@ public List<ResultRow> executeInternalQuery() {
                     analyze(context.getSessionVariable().toThrift());
                 }
             } catch (Exception e) {
-                LOG.warn("Internal SQL execution failed, SQL: {}", originStmt, e);

Review Comment:
   why remove log?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org