You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/05/29 09:39:11 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24241: fix(trino,mysql): handle string typed decimal results
codecov[bot] commented on PR #24241:
URL: https://github.com/apache/superset/pull/24241#issuecomment-1566854764
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24241?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24241](https://app.codecov.io/gh/apache/superset/pull/24241?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (eaf4923) into [master](https://app.codecov.io/gh/apache/superset/commit/50535e427e51743e298d46009d51b08ef2380012?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (50535e4) will **decrease** coverage by `11.21%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head eaf4923 differs from pull request most recent head f5a2f73. Consider uploading reports for the commit f5a2f73 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24241 +/- ##
===========================================
- Coverage 68.30% 57.10% -11.21%
===========================================
Files 1957 1957
Lines 75594 75610 +16
Branches 8224 8224
===========================================
- Hits 51637 43177 -8460
- Misses 21849 30325 +8476
Partials 2108 2108
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.29% <62.96%> (+<0.01%)` | :arrow_up: |
| python | `59.64% <100.00%> (-23.18%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.44% <100.00%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://app.codecov.io/gh/apache/superset/pull/24241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `76.86% <100.00%> (-13.94%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://app.codecov.io/gh/apache/superset/pull/24241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.16% <100.00%> (-20.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/trino.py](https://app.codecov.io/gh/apache/superset/pull/24241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RyaW5vLnB5) | `79.36% <100.00%> (-4.38%)` | :arrow_down: |
... and [303 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24241/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org