You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/29 20:46:37 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #5955: [AIRFLOW-5350] Fix bug in the num_retires field in BigQueryHook

mik-laj commented on a change in pull request #5955: [AIRFLOW-5350] Fix bug in the num_retires field in BigQueryHook
URL: https://github.com/apache/airflow/pull/5955#discussion_r319264366
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -56,7 +56,7 @@ def __init__(self,
             gcp_conn_id=bigquery_conn_id, delegate_to=delegate_to)
         self.use_legacy_sql = use_legacy_sql
         self.location = location
-        self.num_retries = self._get_field('num_retries', 5)
+        self.num_retries = self._get_field('num_retries', 5) or 5
 
 Review comment:
   This code is repeated in many places. Does this not cause problems elsewhere?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services