You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "koarz (via GitHub)" <gi...@apache.org> on 2025/04/16 02:26:58 UTC
[PR] [feat](binlog) add modify distribution type binlog [doris]
koarz opened a new pull request, #50077:
URL: https://github.com/apache/doris/pull/50077
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](binlog) add modify distribution type binlog [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50077:
URL: https://github.com/apache/doris/pull/50077#issuecomment-2826639553
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](binlog) add modify distribution type binlog [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50077:
URL: https://github.com/apache/doris/pull/50077#issuecomment-2808108431
TeamCity cloud ut coverage result:
Function Coverage: 83.00% (1089/1312)
Line Coverage: 66.06% (18166/27500)
Region Coverage: 65.51% (8953/13666)
Branch Coverage: 55.35% (4823/8714)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8590b86c8f89cc4dafa933256f339a2049d8ecd5_8590b86c8f89cc4dafa933256f339a2049d8ecd5_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](binlog) add modify distribution type binlog [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50077:
URL: https://github.com/apache/doris/pull/50077#issuecomment-2808264300
<details>
<summary>ClickBench: <b>Total hot run time: 30.37 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8590b86c8f89cc4dafa933256f339a2049d8ecd5, data reload: false
query1 0.04 0.04 0.02
query2 0.15 0.10 0.10
query3 0.34 0.20 0.20
query4 1.58 0.20 0.19
query5 0.63 0.61 0.62
query6 1.20 0.74 0.72
query7 0.02 0.02 0.01
query8 0.05 0.05 0.05
query9 0.61 0.52 0.52
query10 0.57 0.57 0.57
query11 0.26 0.12 0.12
query12 0.25 0.13 0.13
query13 0.63 0.62 0.62
query14 1.18 1.20 1.19
query15 0.97 0.88 0.88
query16 0.38 0.38 0.36
query17 1.03 1.04 1.05
query18 0.18 0.19 0.19
query19 1.93 1.77 1.83
query20 0.01 0.01 0.02
query21 15.41 1.00 0.69
query22 0.94 0.97 0.75
query23 14.75 1.54 0.76
query24 5.57 0.57 0.28
query25 0.17 0.10 0.09
query26 0.55 0.23 0.19
query27 0.09 0.09 0.09
query28 11.01 1.18 0.57
query29 12.54 4.14 3.46
query30 0.28 0.09 0.07
query31 2.83 0.63 0.44
query32 3.25 0.59 0.50
query33 3.18 3.06 3.11
query34 16.56 5.18 4.48
query35 4.52 4.50 4.52
query36 0.64 0.51 0.50
query37 0.21 0.17 0.16
query38 0.18 0.15 0.15
query39 0.06 0.04 0.05
query40 0.20 0.16 0.15
query41 0.10 0.05 0.05
query42 0.06 0.05 0.05
query43 0.05 0.04 0.05
Total cold run time: 105.16 s
Total hot run time: 30.37 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](binlog) add modify distribution type binlog [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #50077:
URL: https://github.com/apache/doris/pull/50077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](binlog) add modify distribution type binlog [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50077:
URL: https://github.com/apache/doris/pull/50077#issuecomment-2808205646
<details>
<summary>TPC-H: <b>Total hot run time: 34139 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8590b86c8f89cc4dafa933256f339a2049d8ecd5, data reload: false
------ Round 1 ----------------------------------
q1 26186 5089 5010 5010
q2 2072 283 189 189
q3 10408 1271 699 699
q4 10248 1012 534 534
q5 7636 2459 2347 2347
q6 183 161 132 132
q7 950 756 601 601
q8 9324 1290 1096 1096
q9 6768 5149 5174 5149
q10 6830 2318 1877 1877
q11 492 285 278 278
q12 348 372 221 221
q13 17786 3714 3147 3147
q14 236 224 211 211
q15 549 486 488 486
q16 466 454 399 399
q17 620 877 354 354
q18 7590 7212 7152 7152
q19 1568 969 559 559
q20 324 338 221 221
q21 4114 3518 2497 2497
q22 1081 1055 980 980
Total cold run time: 115779 ms
Total hot run time: 34139 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5209 5095 5096 5095
q2 237 331 232 232
q3 2196 2713 2307 2307
q4 1462 1828 1495 1495
q5 4515 4408 4399 4399
q6 222 171 129 129
q7 2032 1959 1801 1801
q8 2636 2616 2554 2554
q9 7297 7124 7171 7124
q10 3009 3201 2779 2779
q11 595 510 512 510
q12 662 787 641 641
q13 3480 3905 3421 3421
q14 277 299 273 273
q15 520 471 475 471
q16 476 519 458 458
q17 1187 1622 1356 1356
q18 7892 7685 7524 7524
q19 818 789 976 789
q20 1967 1970 1853 1853
q21 5375 4901 4989 4901
q22 1127 1097 1006 1006
Total cold run time: 53191 ms
Total hot run time: 51118 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](binlog) add modify distribution type binlog [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50077:
URL: https://github.com/apache/doris/pull/50077#issuecomment-2808045070
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](binlog) add modify distribution type binlog [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50077:
URL: https://github.com/apache/doris/pull/50077#issuecomment-2808241764
<details>
<summary>TPC-DS: <b>Total hot run time: 192758 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8590b86c8f89cc4dafa933256f339a2049d8ecd5, data reload: false
query1 1460 1070 1039 1039
query2 6132 1790 1811 1790
query3 11156 4735 4631 4631
query4 56813 26014 23460 23460
query5 4931 469 447 447
query6 353 204 199 199
query7 4968 492 286 286
query8 318 228 248 228
query9 6258 2557 2555 2555
query10 403 315 250 250
query11 15059 15059 14863 14863
query12 154 115 101 101
query13 1082 520 387 387
query14 10087 6406 6180 6180
query15 217 191 178 178
query16 7125 642 464 464
query17 1073 738 596 596
query18 1584 406 360 360
query19 205 201 178 178
query20 135 133 129 129
query21 209 128 112 112
query22 4342 4405 4396 4396
query23 34061 33553 33442 33442
query24 6443 2447 2430 2430
query25 464 466 399 399
query26 699 265 149 149
query27 2225 505 333 333
query28 3243 2167 2163 2163
query29 586 589 456 456
query30 267 218 195 195
query31 869 858 789 789
query32 100 62 61 61
query33 444 364 310 310
query34 765 856 518 518
query35 797 836 751 751
query36 969 1022 934 934
query37 135 104 81 81
query38 4214 4176 4319 4176
query39 1526 1437 1427 1427
query40 219 117 110 110
query41 55 55 52 52
query42 122 106 115 106
query43 485 505 476 476
query44 1320 798 797 797
query45 180 174 168 168
query46 865 1049 648 648
query47 1864 1941 1791 1791
query48 407 413 307 307
query49 706 503 403 403
query50 674 711 429 429
query51 4196 4255 4147 4147
query52 111 105 99 99
query53 229 251 185 185
query54 579 572 529 529
query55 84 78 81 78
query56 330 312 288 288
query57 1201 1203 1147 1147
query58 259 298 261 261
query59 2774 2843 2646 2646
query60 328 312 304 304
query61 135 138 128 128
query62 732 736 692 692
query63 234 191 194 191
query64 1668 1058 725 725
query65 4394 4366 4346 4346
query66 718 404 301 301
query67 16073 15554 15609 15554
query68 5437 860 528 528
query69 522 322 267 267
query70 1176 1088 1066 1066
query71 472 318 302 302
query72 6176 5043 4812 4812
query73 1166 640 342 342
query74 8907 9084 8707 8707
query75 3489 3161 2713 2713
query76 3705 1186 756 756
query77 547 366 275 275
query78 10042 10161 9256 9256
query79 2663 816 573 573
query80 830 496 439 439
query81 516 257 216 216
query82 709 128 97 97
query83 281 335 230 230
query84 295 103 79 79
query85 813 351 320 320
query86 445 311 294 294
query87 4406 4427 4285 4285
query88 3540 2204 2178 2178
query89 395 305 282 282
query90 1892 204 210 204
query91 143 140 108 108
query92 74 65 59 59
query93 2640 942 586 586
query94 705 427 312 312
query95 372 298 279 279
query96 492 574 269 269
query97 3185 3234 3112 3112
query98 241 206 196 196
query99 1487 1401 1265 1265
Total cold run time: 300576 ms
Total hot run time: 192758 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](binlog) add modify distribution type binlog [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50077:
URL: https://github.com/apache/doris/pull/50077#issuecomment-2826639675
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](binlog) add modify distribution type binlog [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #50077:
URL: https://github.com/apache/doris/pull/50077#issuecomment-2808088184
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](binlog) add modify distribution type binlog [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50077:
URL: https://github.com/apache/doris/pull/50077#issuecomment-2808499895
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/8590b86c8f89cc4dafa933256f339a2049d8ecd5_8590b86c8f89cc4dafa933256f339a2049d8ecd5/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/8590b86c8f89cc4dafa933256f339a2049d8ecd5_8590b86c8f89cc4dafa933256f339a2049d8ecd5/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.59% (14153/26912) |
| Line Coverage | 41.46% (122678/295881) |
| Region Coverage | 40.18% (62438/155391) |
| Branch Coverage | 34.84% (31312/89886) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](binlog) add modify distribution type binlog [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #50077:
URL: https://github.com/apache/doris/pull/50077#issuecomment-2808056291
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org