You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/08/29 09:07:30 UTC
[GitHub] [incubator-seatunnel] ic4y opened a new pull request, #2559: [Engine][Task] Use TaskGroupInfo instead of TaskGroupID
ic4y opened a new pull request, #2559:
URL: https://github.com/apache/incubator-seatunnel/pull/2559
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
Use TaskGroupInfo instead of TaskGroupID.
Solve the problem of the same TaskGroupId of different Jobs with different PipelineIds.
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [x] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2559: [Engine][Task] Use TaskGroupLocation instead of TaskGroupID
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2559:
URL: https://github.com/apache/incubator-seatunnel/pull/2559#discussion_r957988327
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/operation/sink/SinkRegisterOperation.java:
##########
@@ -56,7 +56,7 @@ public void run() throws Exception {
SinkAggregatedCommitterTask<?> task = null;
for (int i = 0; i < RETRY_TIME; i++) {
try {
- task = server.getTaskExecutionService().getExecutionContext(committerTaskID.getTaskGroupID())
Review Comment:
I will create an issue for this as an improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on a diff in pull request #2559: [Engine][Task] Use TaskGroupLocation instead of TaskGroupID
Posted by GitBox <gi...@apache.org>.
ic4y commented on code in PR #2559:
URL: https://github.com/apache/incubator-seatunnel/pull/2559#discussion_r957977242
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/operation/sink/SinkRegisterOperation.java:
##########
@@ -56,7 +56,7 @@ public void run() throws Exception {
SinkAggregatedCommitterTask<?> task = null;
for (int i = 0; i < RETRY_TIME; i++) {
try {
- task = server.getTaskExecutionService().getExecutionContext(committerTaskID.getTaskGroupID())
Review Comment:
Our current TaskID is not unique and may be repeated in different jobs or pipelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2559: [Engine][Task] Use TaskGroupLocation instead of TaskGroupID
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2559:
URL: https://github.com/apache/incubator-seatunnel/pull/2559#discussion_r957972985
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/operation/sink/SinkRegisterOperation.java:
##########
@@ -56,7 +56,7 @@ public void run() throws Exception {
SinkAggregatedCommitterTask<?> task = null;
for (int i = 0; i < RETRY_TIME; i++) {
try {
- task = server.getTaskExecutionService().getExecutionContext(committerTaskID.getTaskGroupID())
Review Comment:
Can the encapsulation of the group-id be improved? Hide details in TaskExecutionService, TaskID is unique for a job, task-group-id & pipeline-id can be hidden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin merged pull request #2559: [Engine][Task] Use TaskGroupLocation instead of TaskGroupID
Posted by GitBox <gi...@apache.org>.
ashulin merged PR #2559:
URL: https://github.com/apache/incubator-seatunnel/pull/2559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2559: [Engine][Task] Use TaskGroupLocation instead of TaskGroupID
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2559:
URL: https://github.com/apache/incubator-seatunnel/pull/2559#discussion_r957972985
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/operation/sink/SinkRegisterOperation.java:
##########
@@ -56,7 +56,7 @@ public void run() throws Exception {
SinkAggregatedCommitterTask<?> task = null;
for (int i = 0; i < RETRY_TIME; i++) {
try {
- task = server.getTaskExecutionService().getExecutionContext(committerTaskID.getTaskGroupID())
Review Comment:
Can the encapsulation of the group-id be improved? Hide details in TaskExecutionService, TaskID is unique for a job, task-group-id can be hidden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2559: [Engine][Task] Use TaskGroupLocation instead of TaskGroupID
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2559:
URL: https://github.com/apache/incubator-seatunnel/pull/2559#issuecomment-1231094148
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org