DO NOT REPLY [Bug 25441] - TestPlan changes sometimes detected incorrectly (isDirty)

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=25441>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=25441


sebb@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From sebb@apache.org  2007-06-03 04:09 -------
(In reply to comment #8)
> (In reply to comment #6)
> > (In reply to comment #4)
> > [...]
> > > The patch also makes the "Load" action close the current testplan only 
when 
> > the
> > > user selects a file to load. This means that if a user now has a 
currently 
> > open
> > > test plan, then uses the "Load" menu option, but clicks "Cancel" in the 
file
> > > dialog, the test plan he had open is still open. Previously, the current 
test
> > > plan was closed before the file dialog appear, which is annoying.
> > 
> > However, I've now fixed the Close action to allow for the user to cancel 
the 
> > close - previously there was no cancel button, and the close (x) button 
was 
> > treated the same as No.
> > 
> > If the user Opens an new file on an unsaved plan, the Save? (Close) dialog 
is 
> > now presented when the user opens the file, and the cancel option is now 
> > ignored, which is also annoying, as the user does not know the plan is 
dirty 
> > until too late...
> > 
> > I think this needs a bit of tweaking.
> > 
> The only way I see this can be improved, is by duplicating the code in the
> "Close" action in the "Load" action, and present the "do you want to save
> changes" dialog from the "Load" action, and then take the necessary steps
> depending on what the user wants.

I've fixed this by putting the Close doAction() code in a static routine that 
can be called by the Load class - see SVN r543879

I think the bug is now all fixed - hoorah!

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org