[jira] Updated: (THRIFT-581) Add a testsuite for txThrift (Twisted)

["Roger Meier (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier updated THRIFT-581:
-------------------------------

    Attachment: THRIFT-581_twisted-testsuite.v2.patch

Hi Esteve, tests are important and that's why I had a look on this patch.

I modified it a bit:
* added namespace py.twisted to ThriftTest.thrift
* ASF License to test_suite.py
* recreate patch 

now [^THRIFT-581_twisted-testsuite.v2.patch] applies to revision 1005758 and from my perspective => ready to commit!

-roger

> Add a testsuite for txThrift (Twisted)
> --------------------------------------
>
>                 Key: THRIFT-581
>                 URL: https://issues.apache.org/jira/browse/THRIFT-581
>             Project: Thrift
>          Issue Type: Test
>          Components: Test Suite
>            Reporter: Esteve Fernandez
>            Assignee: Esteve Fernandez
>            Priority: Critical
>         Attachments: 581-twisted-testsuite.patch, THRIFT-581_twisted-testsuite.v2.patch
>
>
> Thrift lacks a testsuite for Twisted, this is unacceptable and should be addressed as soon as possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.